flashplayer: fix hashes #43412
Merged
flashplayer: fix hashes #43412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would expect additional libraries for the `firefox` expression to be added into the wrapper, not into the builder (as it builds perfectly fine without those). No?
`firefox-bin` is a kind of wrapper already, so it may be ok to put those there in that case, though.
|
|
@volth you have to add
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hashes have been changed (see also #43394).
Moreover,
plugin-containerof Firefox requires a few libraries for Flash player.Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Fits CONTRIBUTING.md.
Built packages
nix-env -i -f . -A pkgs.flashplayernix-build -I nixpkgs=. -A pkgsi686Linux.flashplayernix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"nix-build -I nixpkgs=. -A pkgs.flashplayer-standalonenix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debuggernix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"Played a video with Firefox and Chromium (x86_64).
Checked the version with Firefox, Chromium, flashplayer-standalone, and flashplayer-standalone-debugger (x86_64) http://www.adobe.com/software/flash/about/