lift version restrictions on language-ecmascript inputs #44331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
suggested changes
Aug 2, 2018
There was a problem hiding this comment.
Thank you. Could you please rename your commit according to CONTRIBUTING.md. Something like:
haskell-language-ecmascript: jailbreak to fix the build
| @@ -1125,4 +1125,6 @@ self: super: { | |||
| # Tests require a browser: https://github.com/ku-fpg/blank-canvas/issues/73 | |||
| blank-canvas = dontCheck super.blank-canvas; | |||
| blank-canvas_0_6_2 = dontCheck super.blank-canvas_0_6_2; | |||
|
|
|||
| language-ecmascript = doJailbreak super.language-ecmascript; | |||
There was a problem hiding this comment.
Please add a comment here why the jailbreak is needed. Something like:
# Needed because of testing-feat >=0.4.0.2 && <1.1
With that it's easier to know when we can remove the override again.
jerith666
force-pushed
the
language-ecmascript-jailbreak
branch
from
c19625b
to
afaaac2
Compare
|
Both items done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for testing-feat >=0.4.0.2 && <1.1
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)