Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql-cli: init at 2.16.5 #44353

Merged
merged 1 commit into from Aug 3, 2018
Merged

graphql-cli: init at 2.16.5 #44353

merged 1 commit into from Aug 3, 2018

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Aug 2, 2018

Motivation for this change

graphql-cli is a command-line tool to make GraphQL requests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

infinisil
infinisil reviewed Aug 2, 2018
View reviewed changes
pkgs/development/node-packages/node-env.nix
@@ -56,7 +56,7 @@ let
) dependencies);

# Recursively composes the dependencies of a package
composePackage = { name, packageName, src, dependencies ? [], ... }:
composePackage = { name, packageName, src, dependencies ? [], ... }@args:
Copy link
Member

@infinisil infinisil Aug 2, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this? Was just removed recently because args isn't used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only applied the documented way of adding a package. I have no idea why it's so non-compositional and I have no idea why this reappeared.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, it's auto-generated. Never mind then

@infinisil
Copy link
Member

@GrahamcOfBorg build nodePackages.graphql-cli

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages.graphql-cli

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5
patching script interpreter paths in /nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5
/nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/dist/bin.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/77kg9gk7yr4gv4qafl862s8vfd6nbp57-nodejs-6.14.3/bin/node"
/nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/mime/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/77kg9gk7yr4gv4qafl862s8vfd6nbp57-nodejs-6.14.3/bin/node"
/nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/z-schema/bin/z-schema: interpreter directive changed from "/usr/bin/env node" to "/nix/store/77kg9gk7yr4gv4qafl862s8vfd6nbp57-nodejs-6.14.3/bin/node"
/nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/apollo-codegen/lib/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/77kg9gk7yr4gv4qafl862s8vfd6nbp57-nodejs-6.14.3/bin/node"
/nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/graphql-schema-linter/lib/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/77kg9gk7yr4gv4qafl862s8vfd6nbp57-nodejs-6.14.3/bin/node"
/nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/npm-path/bin/npm-path: interpreter directive changed from "/usr/bin/env node" to "/nix/store/77kg9gk7yr4gv4qafl862s8vfd6nbp57-nodejs-6.14.3/bin/node"
checking for references to /build in /nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5...
/nix/store/lk2hnqym0vpv21qizry9ffc96mpp8ajw-node-graphql-cli-2.16.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages.graphql-cli

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5
patching script interpreter paths in /nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5
/nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/z-schema/bin/z-schema: interpreter directive changed from "/usr/bin/env node" to "/nix/store/as6nqxp6iyky12yfkwfjc5iwcqycz00z-nodejs-6.14.3/bin/node"
/nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/npm-path/bin/npm-path: interpreter directive changed from "/usr/bin/env node" to "/nix/store/as6nqxp6iyky12yfkwfjc5iwcqycz00z-nodejs-6.14.3/bin/node"
/nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/mime/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/as6nqxp6iyky12yfkwfjc5iwcqycz00z-nodejs-6.14.3/bin/node"
/nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/graphql-schema-linter/lib/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/as6nqxp6iyky12yfkwfjc5iwcqycz00z-nodejs-6.14.3/bin/node"
/nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/node_modules/apollo-codegen/lib/cli.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/as6nqxp6iyky12yfkwfjc5iwcqycz00z-nodejs-6.14.3/bin/node"
/nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5/lib/node_modules/graphql-cli/dist/bin.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/as6nqxp6iyky12yfkwfjc5iwcqycz00z-nodejs-6.14.3/bin/node"
checking for references to /build in /nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5...
/nix/store/756zh5n105lkhgbaxk9jw12iijh3bmcp-node-graphql-cli-2.16.5

@infinisil infinisil merged commit da53c12 into NixOS:master Aug 3, 2018
@Zimmi48 Zimmi48 deleted the graphql-cli branch August 3, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zimmi48 @infinisil @GrahamcOfBorg