Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.spglib:1.10.3.75->1.10.4.1 | Fix failing tests #44352

Merged
merged 1 commit into from Aug 2, 2018
Merged

pythonPackages.spglib:1.10.3.75->1.10.4.1 | Fix failing tests #44352

merged 1 commit into from Aug 2, 2018

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@PsyanticY PsyanticY requested a review from FRidh as a code owner August 2, 2018 11:34
@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

@GrahamcOfBorg build python36Packages.spglib python27Packages.spglib

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.spglib, python27Packages.spglib

Partial log (click to expand)


OK
test_niggli_reduce (test_niggli_delaunay.TestNiggliDelaunay) ... ok

----------------------------------------------------------------------
Ran 18 tests in 31.640s

OK
/nix/store/s2dby7wrp5rkrdq85yb22bf3lpicqc31-python3.6-spglib-1.10.4.1
/nix/store/c00bh4nwlkzagcnz5d77ddqf08abr5kk-python2.7-spglib-1.10.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.spglib, python27Packages.spglib

Partial log (click to expand)


OK
test_standardize_cell_to_primitive (test_spglib.TestSpglib) ... ok

----------------------------------------------------------------------
Ran 18 tests in 186.339s

OK
/nix/store/rjkpddv8bzzidb1i26kq9pckzjvrqzi0-python3.6-spglib-1.10.4.1
/nix/store/86s2zqfbicbhic22dmi4pwmhpkwqpvi6-python2.7-spglib-1.10.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.spglib, python27Packages.spglib

Partial log (click to expand)


OK
test_standardize_cell_to_primitive (test_spglib.TestSpglib) ... ok

----------------------------------------------------------------------
Ran 18 tests in 222.091s

OK
/nix/store/gdb3qh8hwnp7xjyiml131vsbw1p5cf5w-python3.6-spglib-1.10.4.1
/nix/store/5l2118pxlj7mplv89kllsxxap55azbvs-python2.7-spglib-1.10.4.1

@xeji xeji merged commit 9b34997 into NixOS:master Aug 2, 2018
@PsyanticY PsyanticY deleted the spglib-2 branch August 2, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PsyanticY @xeji @GrahamcOfBorg