Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinyproxy: init at 1.8.4 #44342

Merged
merged 2 commits into from Aug 2, 2018
Merged

tinyproxy: init at 1.8.4 #44342

merged 2 commits into from Aug 2, 2018

Conversation

carlosdagos
Copy link
Member

Motivation for this change

Tinyproxy is great 馃槃

This should compile for all platforms.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

@GrahamcOfBorg build tinyproxy

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tinyproxy

Partial log (click to expand)

a2x: ERROR: "xsltproc"  --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0  "/nix/store/s2xd83mkhjmck3jf491mq96ygnrg2q4x-asciidoc-8.6.9/etc/asciidoc/docbook-xsl/manpage.xsl" "/build/source/docs/man5/tinyproxy.conf.xml" returned non-zero exit status 5
make[3]: *** [Makefile:522: tinyproxy.conf.5] Error 1
make[3]: Leaving directory '/build/source/docs/man5'
make[2]: *** [Makefile:342: all-recursive] Error 1
make[2]: Leaving directory '/build/source/docs'
make[1]: *** [Makefile:392: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:333: all] Error 2
builder for '/nix/store/s2c6w8090706pvy5k8y4w77gpws40lic-tinyproxy-1.8.4.drv' failed with exit code 2
error: build of '/nix/store/s2c6w8090706pvy5k8y4w77gpws40lic-tinyproxy-1.8.4.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: tinyproxy

Partial log (click to expand)

a2x: ERROR: "xsltproc"  --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0  "/nix/store/k4ppgng6ccadfbij08r8dp551azz5p3q-asciidoc-8.6.9/etc/asciidoc/docbook-xsl/manpage.xsl" "/build/source/docs/man5/tinyproxy.conf.xml" returned non-zero exit status 5
make[3]: *** [Makefile:522: tinyproxy.conf.5] Error 1
make[3]: Leaving directory '/build/source/docs/man5'
make[2]: *** [Makefile:342: all-recursive] Error 1
make[2]: Leaving directory '/build/source/docs'
make[1]: *** [Makefile:392: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:333: all] Error 2
builder for '/nix/store/2411syid1dx7wagl26sr9jnwq6y1dicr-tinyproxy-1.8.4.drv' failed with exit code 2
error: build of '/nix/store/2411syid1dx7wagl26sr9jnwq6y1dicr-tinyproxy-1.8.4.drv' failed

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

Looks like building the manpages fails.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tinyproxy

Partial log (click to expand)

make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-tinyproxy-1.8.4.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-tinyproxy-1.8.4.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/lbljdqn2ac0a9f4sbz0wlrz5rswqqas0-tinyproxy-1.8.4/share/man/
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lbljdqn2ac0a9f4sbz0wlrz5rswqqas0-tinyproxy-1.8.4/sbin
patching script interpreter paths in /nix/store/lbljdqn2ac0a9f4sbz0wlrz5rswqqas0-tinyproxy-1.8.4
moving /nix/store/lbljdqn2ac0a9f4sbz0wlrz5rswqqas0-tinyproxy-1.8.4/sbin/* to /nix/store/lbljdqn2ac0a9f4sbz0wlrz5rswqqas0-tinyproxy-1.8.4/bin
/nix/store/lbljdqn2ac0a9f4sbz0wlrz5rswqqas0-tinyproxy-1.8.4

xeji
xeji suggested changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix failing builds

@carlosdagos
Copy link
Member Author

Thanks for reviewing @xeji, I鈥檒l revisit this and fix the manpages issue

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

Please also make sure you build packages locally with sandboxing enabled. This makes it much more likely that if it builds locally, it will also build on our CI.

@carlosdagos
Copy link
Member Author

carlosdagos commented Aug 2, 2018 •
edited

Managed to reproduce by turning off my internet connection:

a2x: ERROR: "xsltproc"  --stringparam callout.graphics 0 --stringparam navig.graphics 0 --stringparam admon.textlabel 1 --stringparam admon.graphics 0  "/nix/store/s2xd83mkhjmck3jf491mq96ygnrg2q4x-asciidoc-8.6.9/etc/asciidoc/docbook-xsl/manpage.xsl" "/tmp/nix-build-tinyproxy-1.8.4.drv-0/source/docs/man5/tinyproxy.conf.xml" returned non-zero exit status 5

It happens because xsltproc can't find some DTDs (apparently) and reaches to the internet to get them. However just adding a nonet option and a native dependency on docbook_xsl should fix it (testing locally seems fine using NixOS).

Thanks again @xeji

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

@GrahamcOfBorg build tinyproxy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tinyproxy

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4
shrinking /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4/sbin/tinyproxy
gzipping man pages under /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4/sbin
patching script interpreter paths in /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4
checking for references to /build in /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4...
moving /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4/sbin/* to /nix/store/vc67fwpmrhy521kvcffisf2fira8n1cr-tinyproxy-1.8.4/bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tinyproxy

Partial log (click to expand)

make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-tinyproxy-1.8.4.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-tinyproxy-1.8.4.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/q1r0011bng15jvl2rpj4b9xrp5d5h9g9-tinyproxy-1.8.4/share/man/
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q1r0011bng15jvl2rpj4b9xrp5d5h9g9-tinyproxy-1.8.4/sbin
patching script interpreter paths in /nix/store/q1r0011bng15jvl2rpj4b9xrp5d5h9g9-tinyproxy-1.8.4
moving /nix/store/q1r0011bng15jvl2rpj4b9xrp5d5h9g9-tinyproxy-1.8.4/sbin/* to /nix/store/q1r0011bng15jvl2rpj4b9xrp5d5h9g9-tinyproxy-1.8.4/bin
/nix/store/q1r0011bng15jvl2rpj4b9xrp5d5h9g9-tinyproxy-1.8.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tinyproxy

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4
shrinking /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4/sbin/tinyproxy
gzipping man pages under /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4/sbin
patching script interpreter paths in /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4
checking for references to /build in /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4...
moving /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4/sbin/* to /nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4/bin
/nix/store/gxmxx3x112gzxvkziwbwcnijynjiv44a-tinyproxy-1.8.4

@xeji
Copy link
Contributor

xeji commented Aug 2, 2018

Thank you, LGTM now.

Managed to reproduce by turning off my internet connection:

That's one reason to enable sandboxed builds on your local machine. The sandbox denies network access, so you would have caught this error right away.

@xeji xeji merged commit 5c7bf43 into NixOS:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlosdagos @xeji @GrahamcOfBorg