Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencollada: add license #44345

Merged
merged 1 commit into from Aug 2, 2018
Merged

opencollada: add license #44345

merged 1 commit into from Aug 2, 2018

Conversation

pSub
Copy link
Member

@pSub pSub commented Aug 2, 2018

see issue #43716

Motivation for this change

add missing license

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pSub pSub mentioned this pull request Aug 2, 2018
Open
davidak
davidak approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pSub pSub merged commit 216633e into master Aug 2, 2018
@pSub pSub deleted the opencollada-license branch August 2, 2018 10:18
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: opencollada

Partial log (click to expand)

/build/source/Externals/MathMLSolver/src/AST/MathMLASTConstantExpression.cpp:28:9: warning: base class 'class MathML::AST::INode' should be explicitly initialized in the copy constructor [-Wextra]
         ConstantExpression::ConstantExpression( const ConstantExpression& ref )
         ^~~~~~~~~~~~~~~~~~
[ 22%] Linking CXX static library ../../lib/libMathMLSolver.a
[ 22%] Built target MathMLSolver_static
[ 22%] Linking CXX static library ../lib/libDAEValidatorLibrary.a
[ 22%] Built target DAEValidatorLibrary
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/3s2fxymq2pkz89ivpajcm6a2k74yab9f-opencollada-1.6.63.drv' failed with exit code 2
error: build of '/nix/store/3s2fxymq2pkz89ivpajcm6a2k74yab9f-opencollada-1.6.63.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: opencollada

Partial log (click to expand)

[ 26%] Built target buffer_static
make[1]: *** [CMakeFiles/Makefile2:362: COLLADABaseUtils/CMakeFiles/OpenCOLLADABaseUtils_static.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 26%] Linking CXX static library ../../lib/libMathMLSolver.a
[ 26%] Built target MathMLSolver_static
[ 26%] Linking CXX static library ../lib/libDAEValidatorLibrary.a
[ 26%] Built target DAEValidatorLibrary
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/54jn0jjaj3l1pys8jf5smm3na8nk4z6j-opencollada-1.6.63.drv' failed with exit code 2
error: build of '/nix/store/54jn0jjaj3l1pys8jf5smm3na8nk4z6j-opencollada-1.6.63.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pSub @GrahamcOfBorg @davidak