Drop gnome3.gconf #43268
Merged
Drop gnome3.gconf #43268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
the
6.topic: GNOME
This comment has been minimized.
This comment has been minimized.
jtojnar
force-pushed
the
drop-gnome3-gconf
branch
2 times, most recently
from
abe9d13
to
397986d
Compare
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: gnome2.GConf Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gnome2.GConf Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gnome2.GConf Partial log (click to expand)
|
GrahamcOfBorg
added
6.topic: haskell
6.topic: nixos
6.topic: python
6.topic: stdenv
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: gnome2.GConf Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gnome2.GConf Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gnome2.GConf Partial log (click to expand)
|
Update and clean up the expression. For example, GTK was only used for removed utility and examples.
jtojnar
force-pushed
the
drop-gnome3-gconf
branch
from
397986d
to
28b6f74
Compare
GrahamcOfBorg
added
6.topic: haskell
6.topic: nixos
6.topic: python
6.topic: stdenv
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: gnome2.GConf Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: gnome2.GConf Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gnome2.GConf Partial log (click to expand)
|
|
I would really like this to be a warning instead: {
gconf = throw "gconf has been removed because it's a pile of trash, see #43268";
}I had to look through |
9 tasks
infinisil
added a commit
to infinisil/system
that referenced
this pull request
Aug 24, 2018
jtojnar
added a commit
to jtojnar/nixpkgs
that referenced
this pull request
Aug 25, 2018
NixOS#43268 removed GConf from GNOME 3 package set, let’s add an error for a little while to save people digging through the commit log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Change
gnome3.gconfin your nix files tognome2.GConf.Things done
As GConf has been deprecated for ages, I updated it in
gnome2and removed it fromgnome3. I would like to remove GConf altogether (just like Debian is finally doing) but since some packages still needed it, I decided to keep it in the legacygnome2attribute. Eventually, we will probably move it to top-level whengnome2gets removed (#39976).sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)