New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert removal of linux_testing_bcachefs
from "linux: remove versions unmaintained upstream"
#43257
Conversation
…ns unmaintained upstream" This reverts parts of commit 298e170.
cc @vcunat who committed the removal. |
Builds fine with this revert. |
The entire commit should be reverted because we really shouldn't remove packages on the stable branch. For example, it breaks
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose people choosing *_testing_bcachefs
know the potential security risks from lagging months behind.
I am quite out of the loop on whatever the kernel support cycle is and entails, but that's quite a regression to me, and the presented reasoning doesn't impress me in the slightest. Yes, bcachefs is currently only present for 4.15. Yes, that version may be unmaintained and, in general, bcachefs is quite a non-standard little tested feature. But still, it was in stable NixOS for quite some time, always lagging behind a bit. No, dropping it out of nowhere because you found out it lags behind once again is not acceptable. We know what we are doing, thank you. We don't really have an option other than to use it on 4.15. Now bring it back, as we have no other option of using it. If you hold something substantial against shipping it in stable, let's discuss it and consider dropping it for the next release, but not now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some demand for it and adding it back won't break anything else. But let's reconsider for 18.09.
Revert removal of
linux_testing_bcachefs
from "linux: remove versions unmaintained upstream"This reverts parts of commit 298e170.
Motivation for this change
Some users were relying on
linux_testing_bcachefs
to build and boot their systems:This commit is a
git revert --no-commit 298e170b36b79f4c6b19816a7abbf8392a490840
with careful work to only pick back the relevant bits.I have not personally tested this other than evaluating and compiling. I am assuming it will work since this is a revert. Furthermore, I am not dogfooding this.
Finally, I'm not 100% sure of the reason for removing
linux_testing_bcachefs
in 18.03. If there is any reason not to put it back, close this. I have made the fix mainly because I could.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)Size impact should be minimal, probably nil when comparing to what the size was before the removal.