Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of linux_testing_bcachefs from "linux: remove versions unmaintained upstream" #43257

Merged
merged 1 commit into from Jul 9, 2018

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jul 9, 2018

Revert removal of linux_testing_bcachefs from "linux: remove versions unmaintained upstream"

This reverts parts of commit 298e170.

Motivation for this change

Some users were relying on linux_testing_bcachefs to build and boot their systems:

This commit is a git revert --no-commit 298e170b36b79f4c6b19816a7abbf8392a490840 with careful work to only pick back the relevant bits.

I have not personally tested this other than evaluating and compiling. I am assuming it will work since this is a revert. Furthermore, I am not dogfooding this.

Finally, I'm not 100% sure of the reason for removing linux_testing_bcachefs in 18.03. If there is any reason not to put it back, close this. I have made the fix mainly because I could.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • 🆖 macOS
    • ❌ other Linux distributions
  • ❌ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ⬜ Tested execution of all binary files (usually in ./result/bin/)
  • ❌ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Fits CONTRIBUTING.md.

Size impact should be minimal, probably nil when comparing to what the size was before the removal.


…ns unmaintained upstream"

This reverts parts of commit 298e170.
@xeji
Copy link
Contributor

xeji commented Jul 9, 2018

cc @vcunat who committed the removal.

@t184256
Copy link
Contributor

t184256 commented Jul 9, 2018

Builds fine with this revert.

@edolstra
Copy link
Member

edolstra commented Jul 9, 2018

The entire commit should be reverted because we really shouldn't remove packages on the stable branch. For example, it breaks

boot.kernelPackages = pkgs.linuxPackages_testing;

@vcunat
Copy link
Member

vcunat commented Jul 9, 2018

  • I consider it good to remove unmaintained explicitly versioned kernel branches. Those explicit attributes are just an artifact of supporting _latest on 18.03; I can't see what to improve about this workflow.
  • linux_testing (at 4.16-rc4) was removed halfway (by me) and that's certainly bad. For now I made it an alias of _latest 5e10df3. I don't expect people will backport -RC bumps to 18.03, but if they do, we can point it to them.
  • This MR: on a superficial look it appeared to be some 4.15 kernel, and I assumed those are unmaintained upstream (i.e. possibly vulnerable).

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose people choosing *_testing_bcachefs know the potential security risks from lagging months behind.

@t184256
Copy link
Contributor

t184256 commented Jul 9, 2018

I am quite out of the loop on whatever the kernel support cycle is and entails, but that's quite a regression to me, and the presented reasoning doesn't impress me in the slightest.

Yes, bcachefs is currently only present for 4.15. Yes, that version may be unmaintained and, in general, bcachefs is quite a non-standard little tested feature. But still, it was in stable NixOS for quite some time, always lagging behind a bit. No, dropping it out of nowhere because you found out it lags behind once again is not acceptable. We know what we are doing, thank you. We don't really have an option other than to use it on 4.15. Now bring it back, as we have no other option of using it. If you hold something substantial against shipping it in stable, let's discuss it and consider dropping it for the next release, but not now.

Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some demand for it and adding it back won't break anything else. But let's reconsider for 18.09.

@xeji xeji merged commit aec2178 into NixOS:release-18.03 Jul 9, 2018
@samueldr samueldr deleted the fix/revert-bcachefs branch July 10, 2018 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants