xcbuild refactor #43256
Merged
xcbuild refactor #43256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: xcbuild Partial log (click to expand)
|
|
@GrahamcOfBorg build darwin.adv_cmds unixtools |
|
Success on aarch64-linux (full log) Attempted: unixtools The following builds were skipped because they don't evaluate on aarch64-linux: darwin.adv_cmds Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: unixtools The following builds were skipped because they don't evaluate on x86_64-linux: darwin.adv_cmds Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: darwin.adv_cmds The following builds were skipped because they don't evaluate on x86_64-darwin: unixtools Partial log (click to expand)
|
|
@GrahamcOfBorg build unixtools.procps unixtools.utillinux unixtools.nettools |
|
Success on x86_64-linux (full log) Attempted: unixtools.procps, unixtools.utillinux, unixtools.nettools Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: unixtools.procps, unixtools.utillinux, unixtools.nettools Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: unixtools.procps, unixtools.utillinux, unixtools.nettools Partial log (click to expand)
|
This reworks some of xcbuild logic to make it more compatible with Apple’s SDK. - Add a fake version of xcrun & xcode-select - Cleanup platform generation. Clang does not like having 20 char hashes in sysroot so it is much easier to just build the parent directory for each runCommand. This is a little awkward but I have renamed everything with an added ‘s’ to make the distinction more clear. - Cleaned up wrapper.nix in some different ways - Reuse some versioning logic so that we don’t end up with two different versions of Xcode or SDK reported.
Not every package that needs xcbuild will want to use its build phase. I have moved the xcbuild setup hook to the new attribute xcbuildHook. This means that dontUseXcbuild is no longer needed. If you just need to call xcbuild on its own you can just refer to xcbuild.
You can now refer to it as xcodebuild. This is meant to be more discoverable for not familiar with xcbuild. xcodebuild should work in the same way as the xcodebuild that comes with Xcode.app, but it is built entirely with free software.
matthewbauer
force-pushed
the
xcbuild-refactor
branch
from
3ce2064
to
2621171
Compare
|
Success on aarch64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: xcbuild Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: xcbuild Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors xcbuild to better emulate the real Xcodebuild. Hoping to use this to get rid of some of the "no-xcode" patches that exist in Nixpkgs.
I have a branch with some fixes for bazel as well but want to get these infrastructure things included first.