Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 4af706ba9246
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: c158f43b37b8
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 9, 2018

  1. stdenv-setup: Remove superfluous check for /bin/sh 

    The line was essentially checking whether /bin/sh exists and is
executable and if that's the case, the isScript function returns
successfully.

When asking the author of this line on IRC it seems that even they can't
remember or imagine what this was supposed to be.

In summary: Whenever /bin/sh doesn't exist during a build, *any* file
given to isScript is reported as being a script even if it isn't.

This is kinda counter-intuitive and not something what somebody would
expect from a function called "isScript".

Signed-off-by: aszlig <aszlig@nix.build>
Cc: @edolstra
(cherry picked from commit 739c835)
    @aszlig
    aszlig committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    c158f43 View commit details
    Browse the repository at this point in the history