Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron: add gtk2 dependency #43379

Merged
merged 1 commit into from Jul 14, 2018
Merged

electron: add gtk2 dependency #43379

merged 1 commit into from Jul 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2018

Motivation for this change

Fix Rambox after #42769
Closes #43297

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 11, 2018

If we want to fix this globally, we should probably add this to

nixpkgs/pkgs/development/tools/electron/default.nix

Line 50 in 629c901

--set-rpath "${atomEnv.libPath}:$out/lib/electron" \
. But updating electron to support gtk3 would probably be better.

@ghost
Copy link
Author

ghost commented Jul 12, 2018

@jtojnar Done, thanks!

@xeji
Copy link
Contributor

xeji commented Jul 14, 2018

@GrahamcOfBorg build rambox electron

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: electron

The following builds were skipped because they don't evaluate on x86_64-linux: rambox

Partial log (click to expand)

  inflating: /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2/lib/electron/locales/el.pak  
shrinking RPATHs of ELF executables and libraries in /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2
shrinking /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2/lib/electron/libffmpeg.so
shrinking /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2/lib/electron/libnode.so
shrinking /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2/lib/electron/electron
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2/lib  /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2/bin 
patching script interpreter paths in /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2
checking for references to /tmp/nix-build-electron-1.8.2.drv-0 in /nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2...
/nix/store/gqqffzmwfvg356xgvpwd50c037nc21l2-electron-1.8.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: electron

The following builds were skipped because they don't evaluate on x86_64-darwin: rambox

Partial log (click to expand)


b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


these paths will be fetched (33.16 MiB download, 115.18 MiB unpacked):
  /nix/store/hfpc484f4f7cfkrkinpap2d194r2fcva-electron-1.8.2
copying path '/nix/store/hfpc484f4f7cfkrkinpap2d194r2fcva-electron-1.8.2' from 'https://cache.nixos.org'...
/nix/store/hfpc484f4f7cfkrkinpap2d194r2fcva-electron-1.8.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: electron

The following builds were skipped because they don't evaluate on aarch64-linux: rambox

Partial log (click to expand)

  inflating: /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2/lib/electron/locales/cs.pak
shrinking RPATHs of ELF executables and libraries in /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2
shrinking /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2/lib/electron/libnode.so
shrinking /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2/lib/electron/libffmpeg.so
shrinking /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2/lib/electron/electron
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2/lib  /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2/bin
patching script interpreter paths in /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2
checking for references to /build in /nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2...
/nix/store/8kmi3qy84qh39ji495lkbvnbj7ddyn9r-electron-1.8.2

@xeji xeji changed the title rambox: add gtk2 dependency electron: add gtk2 dependency Jul 14, 2018
@xeji xeji merged commit 1727513 into NixOS:master Jul 14, 2018
eqyiel pushed a commit to eqyiel/nixpkgs that referenced this pull request Jul 15, 2018
@eqyiel
electron: add gtk2 dependency (NixOS#43379)
7213f30
@ghost
Copy link
Author

ghost commented Jul 15, 2018

@xeji Thank you!

@ghost ghost deleted the rambox branch July 15, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @xeji @GrahamcOfBorg