Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openrct2: 0.1.2 -> 0.2.0 #43386

Merged
merged 1 commit into from Jul 13, 2018
Merged

openrct2: 0.1.2 -> 0.2.0 #43386

merged 1 commit into from Jul 13, 2018

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jul 11, 2018

Motivation for this change

Updated to current release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 12, 2018

@GrahamcOfBorg build openrct2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openrct2

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openrct2

Partial log (click to expand)

-- Installing: /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0/share/man/man6/openrct2.6
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0
shrinking /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0/bin/openrct2
shrinking /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0/bin/openrct2-cli
gzipping man pages under /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0/lib  /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0/bin 
patching script interpreter paths in /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0
checking for references to /tmp/nix-build-openrct2-0.2.0.drv-0 in /nix/store/n6lm14zaaw02rfsr4pfrbk462jwnr8s2-openrct2-0.2.0...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: openrct2

Partial log (click to expand)

/nix/store/qrddl3scmpl4fr55smvn5dfwkphwhbnq-SDL2-2.0.8-dev/include/SDL2/SDL_cpuinfo.h:63:5: error: "HAVE_IMMINTRIN_H" is not defined, evaluates to 0 [-Werror=undef]
 #if HAVE_IMMINTRIN_H && !defined(SDL_DISABLE_IMMINTRIN_H)
     ^~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/openrct2.dir/build.make:128: CMakeFiles/openrct2.dir/src/openrct2-ui/UiContext.Linux.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:206: CMakeFiles/openrct2.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/gq05dlwn2qf3pns493s4bcj70x9pml8f-openrct2-0.2.0.drv' failed with exit code 2
error: build of '/nix/store/gq05dlwn2qf3pns493s4bcj70x9pml8f-openrct2-0.2.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Jul 12, 2018 •
edited

Please fix aarch64 failure, current version builds: https://hydra.nixos.org/job/nixpkgs/trunk/openrct2.aarch64-linux

@oxzi
Copy link
Member Author

oxzi commented Jul 13, 2018

I'd love to fix the aarch64-build, but I do not know what causes this problems. The error log hints to SDL2, where this define seems to be missing on the aarch64-branch.

Furthermore, I am not sure if this games even runs on other platforms than x86_64, which is btw the only target on the official website.

@xeji
Copy link
Contributor

xeji commented Jul 13, 2018

Furthermore, I am not sure if this games even runs on other platforms than x86_64, which is btw the only target on the official website.

Good point. So let's merge it anyway, maybe someone else wants to fix it for aarch64 later.

@xeji xeji merged commit b12597d into NixOS:master Jul 13, 2018
@oxzi oxzi deleted the openrct2-v0.2.0 branch July 14, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @FRidh @GrahamcOfBorg @xeji