Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Fix typo fixed-points to fixedPoints #43387

Closed
wants to merge 1 commit into from
Closed

lib: Fix typo fixed-points to fixedPoints #43387

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

Motivation for this change

CC @mdorman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mdorman
Copy link
Contributor

mdorman commented Jul 11, 2018

I tried applying this change (by hand, admittedly), and it doesn't appear to work. I see:

error: value is a function while a set was expected

@Ericson2314
Copy link
Member Author

Do you have a nix-instantiate I can use to try out?

@mdorman
Copy link
Contributor

mdorman commented Jul 11, 2018

I have an overlay that I've reduced to:

self: super:

{
  testEmacsPackageSet = super.emacsPackagesNg.overrideScope (emacsSuper: emacsSelf: {
    magit = emacsSelf.melpaStablePackages.magit;
  });
  testEmacsPackages = self.testEmacsPackageSet.emacsWithPackages (emacsSelf: (with emacsSelf;
  [
    magit
  ]));
  testEmacsTools = super.buildEnv (with self; {
    name = "testEmacsTools";
    paths = [
      testEmacsPackages
    ];
  });
}

and when I try to install it I get:

/var/nixup/nixpkgs $ nix-env --file /var/nixup/nixpkgs --install --no-build-output --dry-run --attr testEmacsTools
(dry run; not doing anything)
installing 'testEmacsTools'
error: attribute 'fixed-points' missing, at /var/nixup/nixpkgs/lib/customisation.nix:205:14
(use '--show-trace' to show detailed location information)

@infinisil
Copy link
Member

See 48ccdf3#commitcomment-29678643, it's not just a typo, it's actually a completely different thing. I already reverted it in 4794aa5

@infinisil infinisil closed this Jul 12, 2018
@Ericson2314 Ericson2314 deleted the lib-customize-typo branch August 23, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ericson2314 @mdorman @infinisil @GrahamcOfBorg