Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] qutebrowser: fix CVE-2018-10895 #43368

Merged
merged 1 commit into from Jul 11, 2018
Merged

[18.03] qutebrowser: fix CVE-2018-10895 #43368

merged 1 commit into from Jul 11, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

qutebrowser/qutebrowser#4060

Things done

Note that I did not run the binary because I'm on a different Qt version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

xeji
xeji approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and runs fine on my machine

@xeji xeji merged commit e38e163 into NixOS:release-18.03 Jul 11, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qutebrowser

Partial log (click to expand)

/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3/share/qutebrowser/userscripts/cast: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3/share/qutebrowser/userscripts/readability: interpreter directive changed from "/usr/bin/env python" to "/nix/store/gxay7sx4jv1l69kcif1vw6vb28fsciws-python3-3.6.5/bin/python"
/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3/share/qutebrowser/scripts/dictcli.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/gxay7sx4jv1l69kcif1vw6vb28fsciws-python3-3.6.5/bin/python3"
/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3/share/qutebrowser/scripts/keytester.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/gxay7sx4jv1l69kcif1vw6vb28fsciws-python3-3.6.5/bin/python3"
/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3/share/qutebrowser/scripts/open_url_in_instance.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3/share/qutebrowser/scripts/importer.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/gxay7sx4jv1l69kcif1vw6vb28fsciws-python3-3.6.5/bin/python3"
checking for references to /build in /nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3...
wrapping `/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3/bin/.qutebrowser-wrapped'...
postPatchMkspecs
/nix/store/ncmpziha9xsdx1h046098s1pd34xp2n0-qutebrowser-1.3.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qutebrowser

Partial log (click to expand)

/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3/share/qutebrowser/userscripts/openfeeds: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/9h2466piwdv00fz9phg3an7p0bf2bkr7-python3-3.6.5/bin/python3"
/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3/share/qutebrowser/userscripts/open_download: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1gk1g42x90yp3avlz3grxv917ppvqf5s-bash-4.4-p12/bin/bash"
/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3/share/qutebrowser/userscripts/getbib: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/9h2466piwdv00fz9phg3an7p0bf2bkr7-python3-3.6.5/bin/python3"
/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3/share/qutebrowser/userscripts/format_json: interpreter directive changed from "/bin/sh" to "/nix/store/1gk1g42x90yp3avlz3grxv917ppvqf5s-bash-4.4-p12/bin/sh"
/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3/share/qutebrowser/userscripts/dmenu_qutebrowser: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1gk1g42x90yp3avlz3grxv917ppvqf5s-bash-4.4-p12/bin/bash"
/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3/share/qutebrowser/userscripts/cast: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/1gk1g42x90yp3avlz3grxv917ppvqf5s-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3...
wrapping `/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3/bin/.qutebrowser-wrapped'...
postPatchMkspecs
/nix/store/r0xzyyhdzg5lqwipn18zgz8i91kkrjx6-qutebrowser-1.3.3

@dotlambda dotlambda deleted the qutebrowser-cve-2018-10895 branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @timokau @xeji