Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 4794aa5de233
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7b87554ca16b
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Jul 12, 2018

  1. nixos/tests/letsencrypt: Fix go source install 

    Since e95f17e, Go packages no longer
contain the source tree, however Boulder seems to need that as it
generates a few files during build.

Ideally we would only pick the files that are needed and put it into a
separate output, but I currently don't have time for this so I'm marking
this with XXX to get back to it later.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Jul 12, 2018
    Copy the full SHA
    c21b1ed View commit details
    Browse the repository at this point in the history

  2. nixos/tests/letsencrypt: Hardcode certs and keys 

    In 0c7c166 I have set allowSubstitutes
to false, which avoided the substitution of the certificates.

Unfortunately substitution may still happen later when the certificate
is merged with the CA bundle. So the merged CA bundle might be
substituted from a binary cache but the certificate itself is built
locally, which could result in a different certificate in the bundle.

So instead of adding just yet another workaround, I've now hardcoded all
the certificates and keys in a separate file. This also moves
letsencrypt.nix into its own directory so we don't mess up
nixos/tests/common too much.

This was long overdue and should finally make the dependency graph for
the ACME test more deterministic.

Signed-off-by: aszlig <aszlig@nix.build>
    @aszlig
    aszlig committed Jul 12, 2018
    Copy the full SHA
    7b87554 View commit details
    Browse the repository at this point in the history