libphonenumber: init at 8.9.9 #43397

illegalprime · 2018-07-12T01:53:17Z

Motivation for this change

Adds libphonenumber a handy library to parse and work with phone number of different formats.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

This is my first package contribution here, so I'm sorry in advance if I don't have everything formatted.

FRidh · 2018-07-12T05:17:29Z

Thanks. Please do check https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes.

FRidh · 2018-07-12T05:20:36Z

@GrahamcOfBorg build libphonenumber

GrahamcOfBorg · 2018-07-12T05:20:47Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: libphonenumber

Partial log (click to expand)

Cannot nix-instantiate `libphonenumber' because:
error: attribute 'libphonenumber' in selection path 'libphonenumber' not found

GrahamcOfBorg · 2018-07-12T05:20:52Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libphonenumber

Partial log (click to expand)

Cannot nix-instantiate `libphonenumber' because:
�[31;1merror:�[0m attribute 'libphonenumber' in selection path 'libphonenumber' not found

GrahamcOfBorg · 2018-07-12T05:21:00Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: libphonenumber

Partial log (click to expand)

Cannot nix-instantiate `libphonenumber' because:
error: attribute 'libphonenumber' in selection path 'libphonenumber' not found

FRidh · 2018-07-12T05:22:28Z

@GrahamcOfBorg build phonenumber

GrahamcOfBorg · 2018-07-12T05:23:08Z

Failure on x86_64-darwin (full log)

Attempted: phonenumber

Partial log (click to expand)

      ^~~~~~~~~~~~~
/nix/store/qz17zdv0hxangjzb6sbswnxnb6d076dh-icu4c-59.1-dev/include/unicode/unistr.h:3180:7: error: delegating constructors are permitted only in C++11
      UnicodeString(Char16Ptr(buffer), buffLength, buffCapacity) {}
      ^~~~~~~~~~~~~
3 errors generated.
make[2]: *** [CMakeFiles/geocoding.dir/build.make:359: CMakeFiles/geocoding.dir/src/phonenumbers/geocoding/phonenumber_offline_geocoder.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:423: CMakeFiles/geocoding.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/l0k6dyz3kjwy6xw9658cdccbj432zqi4-phonenumber-8.9.9.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/l0k6dyz3kjwy6xw9658cdccbj432zqi4-phonenumber-8.9.9.drv' failed

GrahamcOfBorg · 2018-07-12T05:30:24Z

Success on x86_64-linux (full log)

Attempted: phonenumber

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9
shrinking /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9/lib64/libphonenumber.so.8.9
shrinking /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9/lib64/libgeocoding.so.8.9
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9/lib64
patching script interpreter paths in /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9
checking for references to /build in /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9...
moving /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9/lib64/* to /nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9/lib
/nix/store/yghg2xxgs6qz87wg0b6cgwd8jmdam3v7-phonenumber-8.9.9

GrahamcOfBorg · 2018-07-12T05:36:38Z

Success on aarch64-linux (full log)

Attempted: phonenumber

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9
shrinking /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9/lib64/libgeocoding.so.8.9
shrinking /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9/lib64/libphonenumber.so.8.9
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9/lib64
patching script interpreter paths in /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9
checking for references to /build in /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9...
moving /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9/lib64/* to /nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9/lib
/nix/store/d14l5lq677lixc3ha8cm3g1r3dvpgqrx-phonenumber-8.9.9

illegalprime · 2018-07-12T06:05:12Z

Thanks! Who should I put as the maintainer?

xeji · 2018-07-12T07:25:22Z

If you like you can add yourself to maintainers/maintainer-list.nix and as a maintainer for this package.

matthewbauer · 2018-07-13T18:48:43Z

pkgs/development/libraries/libphonenumber/default.nix

+    license = stdenv.lib.licenses.asl20;
+  };
+
+  configurePhase = "cmake -DCMAKE_INSTALL_PREFIX=$out cpp";


I think you should be able to leave this out & move it to cmakeFlags.

illegalprime · 2018-07-14T05:21:17Z

@matthewbauer how would I specify that the directory with the CMakeLists.txt is cpp?

matthewbauer · 2018-07-17T23:46:15Z

You should just be able to put it in cmakeFlags I believe. It’s not that important though sice i think what you have is equivalent.

You should mark the package as linux only here though because it looks like there is some issues on macOS.

infinisil · 2018-07-29T19:01:57Z

pkgs/development/libraries/libphonenumber/default.nix

+  src = fetchurl {
+    url = "https://github.com/googlei18n/libphonenumber/archive/v${version}.tar.gz";
+    sha256 = "1m2z5hk2yg99sqi70wf26biprhppklwxwyk0g717c1x6yybch13g";
+  };


Use fetchFromGitHub instead.

infinisil · 2018-07-29T19:04:18Z

pkgs/development/libraries/libphonenumber/default.nix

+
+  nativeBuildInputs = [
+    cmake
+  ];


pkgconfig and gmock should probably be in nativeBuildInputs.

infinisil · 2018-07-29T19:05:04Z

pkgs/development/libraries/libphonenumber/default.nix

+    description = "Google's i18n library for parsing and using phone numbers";
+    license = licenses.asl20;
+    maintainers = with maintainers; [ illegalprime ];
+  };


Nitpick: Can you move this meta section to the very bottom? It's somewhat of a convention

infinisil · 2018-07-29T19:05:25Z

pkgs/development/libraries/libphonenumber/default.nix

+
+  checkPhase = "./libphonenumber_test";
+
+  doCheck = true;


I think doCheck is true by default if I'm not mistaken.

infinisil · 2018-07-29T19:08:26Z

pkgs/top-level/all-packages.nix

@@ -4470,6 +4470,8 @@ with pkgs;

  phodav = callPackage ../tools/networking/phodav { };

+  phonenumber = callPackage ../development/libraries/libphonenumber { };


Use libphonenumber instead, and put it in the section of all-packages.nix where other libraries are.

~~I thought this was alphabetical?~~ Never mind my brain messed up

infinisil · 2018-07-29T19:44:20Z

pkgs/development/libraries/libphonenumber/default.nix

+    maintainers = with maintainers; [ illegalprime ];
+  };
+
+  configurePhase = "cmake -DCMAKE_INSTALL_PREFIX=$out cpp";


Remove this and use cmakeDir = "../cpp"; instead.

illegalprime · 2018-08-03T14:43:55Z

Is it better to have version as an argument to this function? Like { version ? "8.9.9" }? Then it would be easy to build different versions, or my understanding of this is just off.

infinisil · 2018-08-03T14:56:29Z

Nah, Nix doesn't generally handle versions like that. And overriding it like that wouldn't change anything in fact, because the source will still point to the old version. This PR looks good to me like this, thanks :)

infinisil · 2018-08-03T14:57:29Z

Oh wait one more thing: Can you make a first commit for adding you as a maintainer and a second one for adding the package?

infinisil · 2018-08-13T17:57:21Z

Ping

illegalprime · 2018-08-13T19:04:37Z

Moving across cities now, I'll try to get to this tonight. Thanks for the reminder!

…

On Mon, Aug 13, 2018, 12:57 PM Silvan Mosberger ***@***.***> wrote: Ping — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43397 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMoRKGgDpPIuG1Ak4xtYehE9tBMrfglks5uQb4GgaJpZM4VMFvJ> .

illegalprime force-pushed the libphonenumber branch from 46b13e3 to ff4ed30 Compare July 12, 2018 01:53

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jul 12, 2018

illegalprime force-pushed the libphonenumber branch from ff4ed30 to 0512ec4 Compare July 12, 2018 06:04

illegalprime changed the title ~~Add libphonenumber package~~ libphonenumber: init at 8.9.9 Jul 12, 2018

matthewbauer reviewed Jul 13, 2018

View reviewed changes

illegalprime force-pushed the libphonenumber branch 2 times, most recently from 5b87016 to 1246529 Compare July 14, 2018 18:23

infinisil requested changes Jul 29, 2018

View reviewed changes

illegalprime force-pushed the libphonenumber branch from 1246529 to 9eb1662 Compare August 2, 2018 21:19

infinisil approved these changes Aug 3, 2018

View reviewed changes

illegalprime added 2 commits August 13, 2018 16:15

maintainers: add @illegalprime

59f88b4

libphonenumber: init at 8.9.9

eca17c4

illegalprime force-pushed the libphonenumber branch from 9eb1662 to eca17c4 Compare August 13, 2018 20:24

infinisil merged commit 78b4d9a into NixOS:master Aug 13, 2018

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libphonenumber: init at 8.9.9 #43397

libphonenumber: init at 8.9.9 #43397

illegalprime commented Jul 12, 2018 •

edited

FRidh commented Jul 12, 2018

FRidh commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

FRidh commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

illegalprime commented Jul 12, 2018

xeji commented Jul 12, 2018

matthewbauer Jul 13, 2018

illegalprime commented Jul 14, 2018

matthewbauer commented Jul 17, 2018

infinisil Jul 29, 2018

infinisil Jul 29, 2018

infinisil Jul 29, 2018

infinisil Jul 29, 2018

infinisil Jul 29, 2018

illegalprime Aug 2, 2018 •

edited

infinisil Jul 29, 2018

illegalprime commented Aug 3, 2018

infinisil commented Aug 3, 2018

infinisil commented Aug 3, 2018

infinisil commented Aug 13, 2018

illegalprime commented Aug 13, 2018 via email

		@@ -4470,6 +4470,8 @@ with pkgs;

		phodav = callPackage ../tools/networking/phodav { };

		phonenumber = callPackage ../development/libraries/libphonenumber { };

libphonenumber: init at 8.9.9 #43397

libphonenumber: init at 8.9.9 #43397

Conversation

illegalprime commented Jul 12, 2018 • edited

Motivation for this change

Things done

FRidh commented Jul 12, 2018

FRidh commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

FRidh commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

GrahamcOfBorg commented Jul 12, 2018

illegalprime commented Jul 12, 2018

xeji commented Jul 12, 2018

matthewbauer Jul 13, 2018

Choose a reason for hiding this comment

illegalprime commented Jul 14, 2018

matthewbauer commented Jul 17, 2018

infinisil Jul 29, 2018

Choose a reason for hiding this comment

infinisil Jul 29, 2018

Choose a reason for hiding this comment

infinisil Jul 29, 2018

Choose a reason for hiding this comment

infinisil Jul 29, 2018

Choose a reason for hiding this comment

infinisil Jul 29, 2018

Choose a reason for hiding this comment

illegalprime Aug 2, 2018 • edited

Choose a reason for hiding this comment

infinisil Jul 29, 2018

Choose a reason for hiding this comment

illegalprime commented Aug 3, 2018

infinisil commented Aug 3, 2018

infinisil commented Aug 3, 2018

infinisil commented Aug 13, 2018

illegalprime commented Aug 13, 2018 via email

illegalprime commented Jul 12, 2018 •

edited

illegalprime Aug 2, 2018 •

edited