vimPlugis.gist-vim: depend on vimPlugins.WebAPI #43399
Conversation
This fixes the following error when using `:Gist` ```vimL Gist: require 'webapi', install https://github.com/mattn/webapi-vim Gist: require 'webapi', install https://github.com/mattn/webapi-vim E117: Unknown function: gist#Gist ```
| @@ -1863,7 +1863,7 @@ rec { | |||
| rev = "f0d63579eab7548cf12f979dc52ef5a370ecbe63"; | |||
| sha256 = "06nix49j4inxy3rkcv32f4ka89g4crqwfqnrm3b76iwwky8m2p17"; | |||
| }; | |||
| dependencies = []; | |||
| dependencies = ["WebAPI"]; | |||
There was a problem hiding this comment.
This will get overwritten unless persisted in nixpkgs/pkgs/misc/vim-plugins/vim2nix/additional-nix-code/. Also I am not sure how this would work for the dependencies field that is usually interfered by vim2nix. If there is no easy way to do this it is better to remove this plugin from nixpkgs/pkgs/misc/vim-plugins/vim-plugin-names and move it up in the file so it will not be automatically updated.
There was a problem hiding this comment.
Dependencies are usually found by a file like this in the plugin repository: https://github.com/MarcWeber/vim-addon-manager/blob/master/addon-info.json
You could make a pull request for gist-vim to add this file. Otherwise you can stick to the alternative I described before.
There was a problem hiding this comment.
Thank you @Mic92 for the review. I filed a PR upstream, if @mattn is not willing to add it upstream, my other options would be to extend nix#NixDerivation to support a concept of additional_dependencies.
There was a problem hiding this comment.
@Mic92 problem with that is it's text substitution and dependencies = []; already gets defined 😕
There was a problem hiding this comment.
Yes I would love to finish my non-viml rewrite some time, so we could get rid of those stupid limitations.
Motivation for this change
I'm trying to use
:Gistfrom NeoVim, but I get the following error:Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)When I try to generate with
nix-shell -p vimPlugins.pluginnames2nix --command "vim-plugin-names-to-nix", I do not see the dependency I've just added. Can someone help to get this fixed? Thanks!