Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-rotate-key: init at 1.0.0 #43384

Merged
merged 1 commit into from Jul 17, 2018
Merged

aws-rotate-key: init at 1.0.0 #43384

merged 1 commit into from Jul 17, 2018

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Jul 11, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Jul 12, 2018
View reviewed changes
pkgs/tools/admin/aws-rotate-key/default.nix Outdated
sha256 = "13q7rns65cj8b4i0s75dbswijpra9z74b462zribwfjdm29by5k1";
};

goDeps = ./deps.nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation typo

@nlewo
Copy link
Member

nlewo commented Jul 12, 2018

@GrahamcOfBorg build aws-rotate-key

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: aws-rotate-key

Partial log (click to expand)

Cannot nix-instantiate `aws-rotate-key' because:
error: attribute 'aws-rotate-key' in selection path 'aws-rotate-key' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: aws-rotate-key

Partial log (click to expand)

Cannot nix-instantiate `aws-rotate-key' because:
error: attribute 'aws-rotate-key' in selection path 'aws-rotate-key' not found

@nlewo
Copy link
Member

nlewo commented Jul 12, 2018

We need to add en entry in all-packages.nix also :)

@mbode
Copy link
Contributor Author

mbode commented Jul 16, 2018

@nlewo Done :)

@nlewo
Copy link
Member

nlewo commented Jul 16, 2018

@GrahamcOfBorg build aws-rotate-key

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-rotate-key

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7hwwddxkxlrr266xzk5a84bc84hyj948-aws-rotate-key-1.0.0-bin
shrinking /nix/store/7hwwddxkxlrr266xzk5a84bc84hyj948-aws-rotate-key-1.0.0-bin/bin/aws-rotate-key
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7hwwddxkxlrr266xzk5a84bc84hyj948-aws-rotate-key-1.0.0-bin/bin
patching script interpreter paths in /nix/store/7hwwddxkxlrr266xzk5a84bc84hyj948-aws-rotate-key-1.0.0-bin
checking for references to /build in /nix/store/7hwwddxkxlrr266xzk5a84bc84hyj948-aws-rotate-key-1.0.0-bin...
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
/nix/store/7hwwddxkxlrr266xzk5a84bc84hyj948-aws-rotate-key-1.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-rotate-key

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nv7r6blkac3lk4zfgw0ypif4flcr0q89-aws-rotate-key-1.0.0-bin
shrinking /nix/store/nv7r6blkac3lk4zfgw0ypif4flcr0q89-aws-rotate-key-1.0.0-bin/bin/aws-rotate-key
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nv7r6blkac3lk4zfgw0ypif4flcr0q89-aws-rotate-key-1.0.0-bin/bin
patching script interpreter paths in /nix/store/nv7r6blkac3lk4zfgw0ypif4flcr0q89-aws-rotate-key-1.0.0-bin
checking for references to /build in /nix/store/nv7r6blkac3lk4zfgw0ypif4flcr0q89-aws-rotate-key-1.0.0-bin...
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
/nix/store/nv7r6blkac3lk4zfgw0ypif4flcr0q89-aws-rotate-key-1.0.0-bin

@nlewo
Copy link
Member

nlewo commented Jul 17, 2018

Thx!

@nlewo nlewo merged commit bac995c into NixOS:master Jul 17, 2018
@mbode mbode deleted the aws-rotate-key branch July 20, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @nlewo @GrahamcOfBorg