Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11: 390.67 -> 390.77 #44822

Merged
merged 2 commits into from Aug 25, 2018
Merged

nvidia_x11: 390.67 -> 390.77 #44822

merged 2 commits into from Aug 25, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 9, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu
Copy link
Member Author

eadwu commented Aug 11, 2018

Not really accurate, latest is 396.51 while 390.77 is the last one with i686 support. Might as well wait for a proper solution to this.

@eadwu eadwu closed this Aug 11, 2018
@ivan
Copy link
Member

ivan commented Aug 11, 2018 •
edited

Why close? It seems like nvidia_x11 stable was tracking the Long Lived Branch version, and 390.77 is a good release.

@eadwu eadwu reopened this Aug 11, 2018
@tkerber
Copy link
Member

tkerber commented Aug 14, 2018

I'd like to note that linuxLatest is now at 4.18, which has known incompatibility with the 390.67 nvidia driver, i.e. linuxLatest.nvidia_x11 is currently broken until this PR is in (which I've tested, does not have the same problem).

@dtzWill
Copy link
Member

dtzWill commented Aug 14, 2018

👍 . I've always had confusion updating nvidia drivers (what "channel" does each follow, is there some testing to be done, is there a reason we can't auto-update these?) but this looks good to me.

And hitting this with linuxPackages_latest here too :3.

@eadwu
Copy link
Member Author

eadwu commented Aug 14, 2018

The "channels" are noted here https://www.nvidia.com/object/unix.html.

@vcunat vcunat mentioned this pull request Aug 24, 2018
Closed
9 tasks
@vcunat
Copy link
Member

vcunat commented Aug 24, 2018

I think bumps after the dot are generally safe, but I'll try to test this PR tomorrow and merge afterwards.

vcunat
vcunat approved these changes Aug 25, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine with 4.18 for me.

eadwu pushed a commit to eadwu/nixpkgs that referenced this pull request Aug 25, 2018
@vcunat
Merge NixOS#44822: nvidia_x11: 390.67 -> 390.77
3d1331f
@vcunat vcunat merged commit 77d49ae into NixOS:master Aug 25, 2018
@eadwu eadwu deleted the nvidia_x11/390.77 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eadwu @ivan @tkerber @dtzWill @vcunat @GrahamcOfBorg