Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yi: fix build #44830

Merged
merged 1 commit into from Aug 9, 2018
Merged

yi: fix build #44830

merged 1 commit into from Aug 9, 2018

Conversation

infinisil
Copy link
Member

Motivation for this change

I have no idea why this needs to be fixed like this, and I have left a blank comment because of that, please don't merge until that's cleared up. It's weird for only yi-language to be in the wrong version, because there are like 10 yi-* packages that each work with each other.

Ping @ryantm @domenkozar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: yi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yi

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/q311d1mklzrr7zzax5jl97bxc2m0dwxn-yi-0.18.0/bin 
patching script interpreter paths in /nix/store/q311d1mklzrr7zzax5jl97bxc2m0dwxn-yi-0.18.0
checking for references to /tmp/nix-build-yi-0.18.0.drv-0 in /nix/store/q311d1mklzrr7zzax5jl97bxc2m0dwxn-yi-0.18.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/0zfib5fdgz8zm9hlppsxcikdr6hsbv1n-yi-0.18.0-doc
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0zfib5fdgz8zm9hlppsxcikdr6hsbv1n-yi-0.18.0-doc
checking for references to /tmp/nix-build-yi-0.18.0.drv-0 in /nix/store/0zfib5fdgz8zm9hlppsxcikdr6hsbv1n-yi-0.18.0-doc...
building path(s) ‘/nix/store/i3zsc1fr1z9ywyk4bk05gyyfm4afqww9-ghc-8.4.3-with-packages’
building path(s) ‘/nix/store/z30k5565aid37p6lfyl77zk3bb3v3hc5-yi-custom-0.0.0.1’
/nix/store/z30k5565aid37p6lfyl77zk3bb3v3hc5-yi-custom-0.0.0.1

basvandijk
basvandijk suggested changes Aug 9, 2018
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix Outdated
sexpr =
appendPatch (overrideCabal super.sexpr (drv: {
isExecutable = false;
libraryHaskellDepends = drv.libraryHaskellDepends ++ [self.QuickCheck];
})) ./patches/sexpr-0.2.1.patch;

#
yi-core = super.yi-core.override { yi-language = self.yi-language_0_18_0; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason yi-language is at version 0.17.1 is because configuration-hackage2nix.yaml specifies that. The reason it specifies that is because yi-core-0.17.1 is in the latest LTS. Since yi-core is apparantely not in the LTS it defaults to the latest version which is 0.18.0. So your override is the right thing to do.

You could add a comment to instruct to remove the override once yi-language >= 0.18 is in the LTS.

@infinisil
Copy link
Member Author

Thanks @basvandijk, that clears things up, I added a comment for that

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: yi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yi

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/q311d1mklzrr7zzax5jl97bxc2m0dwxn-yi-0.18.0/bin
patching script interpreter paths in /nix/store/q311d1mklzrr7zzax5jl97bxc2m0dwxn-yi-0.18.0
checking for references to /build in /nix/store/q311d1mklzrr7zzax5jl97bxc2m0dwxn-yi-0.18.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/0zfib5fdgz8zm9hlppsxcikdr6hsbv1n-yi-0.18.0-doc
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0zfib5fdgz8zm9hlppsxcikdr6hsbv1n-yi-0.18.0-doc
checking for references to /build in /nix/store/0zfib5fdgz8zm9hlppsxcikdr6hsbv1n-yi-0.18.0-doc...
building '/nix/store/i16539nmy7pz9w2b6w5mjnb5mgywpv35-ghc-8.4.3-with-packages.drv'...
building '/nix/store/09lq6gqldbghfzk6z0fh3rp263a0z045-yi-custom-0.0.0.1.drv'...
/nix/store/z30k5565aid37p6lfyl77zk3bb3v3hc5-yi-custom-0.0.0.1

@infinisil infinisil merged commit 29f9fcd into NixOS:master Aug 9, 2018
@infinisil infinisil deleted the fix/yi branch August 9, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk requested changes

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@infinisil @GrahamcOfBorg @basvandijk