Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtiff: update url to patch file #44815

Merged
merged 1 commit into from Aug 9, 2018
Merged

libtiff: update url to patch file #44815

merged 1 commit into from Aug 9, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 9, 2018 •
edited

Motivation for this change

Update patch tiff_4.0.9-5.debian.tar.xz to tiff_4.0.9-6.debian.tar.xz
The requested URL http://http.debian.net/debian/pool/main/t/tiff/tiff_4.0.9-5.debian.tar.xz returned error: 404 Not Found

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 9, 2018

Mass rebuild, please rebase on staging.

@Izorkin Izorkin changed the base branch from master to staging August 9, 2018 17:27
@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 9, 2018

Change to staging.

@xeji
Copy link
Contributor

xeji commented Aug 9, 2018

@GrahamcOfBorg build libtiff

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libtiff

Partial log (click to expand)

cannot build derivation '/nix/store/chg8dk3w5dkg9wra4sfp7r8n9q8kgriv-pkg-config-0.29.2.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/4j06pyhkcyspkqny58cvg9a2r90a2rz8-nasm-2.13.03.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/6w2g3y9g2cxj834f7r48fymf57iq5a25-openssl-1.0.2o.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/1k9izs8kyfqhb8p03xxp5syvl9hsgrqg-libjpeg-turbo-1.5.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/j45g8vx5j7yfpbxic6b0vq9gbhlgwfz6-libssh2-1.8.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/fyzy0z14bij03770936yamgggxfl53z4-nghttp2-1.32.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/jca1bhvzkbfbcibakmp5y089ilj0j18j-curl-7.61.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/kw659v0g4r092vgimfi0haabj688z420-tiff_4.0.9-6.debian.tar.xz.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/qwkq75fwpncch64z3sh5v63mpcac13lq-libtiff-4.0.9.drv': 7 dependencies couldn't be built
error: build of '/nix/store/qwkq75fwpncch64z3sh5v63mpcac13lq-libtiff-4.0.9.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libtiff

Partial log (click to expand)

checking for references to /build in /nix/store/ls1fckmkjkpkllxc35r81zvk9m6i6cwi-libtiff-4.0.9...
shrinking RPATHs of ELF executables and libraries in /nix/store/jcv9kd8z0ny8qnhdxq3ar7dlxwpw4cvz-libtiff-4.0.9-man
gzipping man pages under /nix/store/jcv9kd8z0ny8qnhdxq3ar7dlxwpw4cvz-libtiff-4.0.9-man/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/jcv9kd8z0ny8qnhdxq3ar7dlxwpw4cvz-libtiff-4.0.9-man
checking for references to /build in /nix/store/jcv9kd8z0ny8qnhdxq3ar7dlxwpw4cvz-libtiff-4.0.9-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/g0s3dmsz2w50dczihr2s3gnx9srffwl3-libtiff-4.0.9-doc
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/g0s3dmsz2w50dczihr2s3gnx9srffwl3-libtiff-4.0.9-doc
checking for references to /build in /nix/store/g0s3dmsz2w50dczihr2s3gnx9srffwl3-libtiff-4.0.9-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libtiff

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/5pj4ixw6zjz3bk9zx3jpadmvxjj5vai6-libtiff-4.0.9-man
gzipping man pages under /nix/store/5pj4ixw6zjz3bk9zx3jpadmvxjj5vai6-libtiff-4.0.9-man/share/man/
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5pj4ixw6zjz3bk9zx3jpadmvxjj5vai6-libtiff-4.0.9-man
checking for references to /build in /nix/store/5pj4ixw6zjz3bk9zx3jpadmvxjj5vai6-libtiff-4.0.9-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/461vvqlasjgdk9q44g78mkhqn78wwb0i-libtiff-4.0.9-doc
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/461vvqlasjgdk9q44g78mkhqn78wwb0i-libtiff-4.0.9-doc
checking for references to /build in /nix/store/461vvqlasjgdk9q44g78mkhqn78wwb0i-libtiff-4.0.9-doc...
/nix/store/2f419xamn2saihwibdaq65zikqd62g3m-libtiff-4.0.9-bin

@xeji xeji merged commit 527d3d5 into NixOS:staging Aug 9, 2018
@Izorkin Izorkin deleted the libtiff branch August 10, 2018 06:42
@vcunat
Copy link
Member

vcunat commented Aug 10, 2018

This causes application of two new CVE patches

applying patch debian/patches/CVE-2018-8905.patch
patching file libtiff/tif_lzw.c
applying patch debian/patches/CVE-2018-10963.patch
patching file libtiff/tif_dirwrite.c

@vcunat vcunat mentioned this pull request Aug 10, 2018
Closed
47 tasks
vcunat pushed a commit that referenced this pull request Aug 10, 2018
@Izorkin @vcunat
libtiff: update url to patch file (#44815)
03eebd7 
(cherry picked from commit 527d3d5)
Additionally fixes CVE-2018-8905 and CVE-2018-10963.
@vcunat vcunat added the 8.has: port to stable A PR already has a backport to the stable release. label Aug 10, 2018
vcunat pushed a commit that referenced this pull request Aug 11, 2018
@Izorkin @vcunat
libtiff: update url to patch file (#44815)
99907ae 
(cherry picked from commit 527d3d5)
Additionally fixes CVE-2018-8905 and CVE-2018-10963.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @xeji @GrahamcOfBorg @vcunat