Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

masterpdfeditor: 4.3.89 -> 5.1.00 #44821

Merged
merged 1 commit into from
Aug 9, 2018
Merged

masterpdfeditor: 4.3.89 -> 5.1.00 #44821

merged 1 commit into from
Aug 9, 2018
+12 −12

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 9, 2018

This bumps masterpdfeditor's version to their 5 series.
The download for masterpdfeditor 4 is gone from their servers :-/

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@flokli
masterpdfeditor: 4.3.89 -> 5.1.00

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
02fffd4 
This bumps masterpdfeditor's version to their 5 series.
The download for masterpdfeditor 4 is gone from their servers :-/
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 9, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: masterpdfeditor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: masterpdfeditor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: masterpdfeditor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

xeji
xeji reviewed Aug 9, 2018
View reviewed changes
pkgs/applications/misc/masterpdfeditor/default.nix
};

nativeBuildInputs = [ autoPatchelfHook ];

buildInputs = [ sane-backends qtbase qtsvg ];
buildInputs = [ nss qtbase qtsvg sane-backends stdenv.cc.cc ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is stdenv.cc.cc needed? The package seems to build without it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with nss not yet inside buildInputs, autoPatchelfHook complained first about not being able to find libstdc++.so.6 - that's why I added it.
Seems like this gets pulled in via nss too - not sure if we still want to specify it explicitly…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine then, let's keep it as is.

@xeji
Copy link
Contributor

xeji commented Aug 9, 2018

unfree package, build checked locally, runs fine here.

@xeji xeji merged commit d3977e1 into NixOS:master Aug 9, 2018
@flokli flokli deleted the masterpdfeditor-5.1.00 branch August 12, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @xeji