Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-node-exporter: work around prometheus/node_exporter#870 #44824

Merged
merged 2 commits into from Aug 9, 2018
Merged

prometheus-node-exporter: work around prometheus/node_exporter#870 #44824

merged 2 commits into from Aug 9, 2018

Conversation

lukateras
Copy link
Member

See: prometheus/node_exporter#870

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prometheus-node-exporter

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin
shrinking /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin/bin/node_exporter
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin/bin
patching script interpreter paths in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin
checking for references to /build in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin...
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
/nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prometheus-node-exporter

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v0j3pn7gjrbficw1lmf3x7x8g35n6lvb-node_exporter-0.16.0-bin
shrinking /nix/store/v0j3pn7gjrbficw1lmf3x7x8g35n6lvb-node_exporter-0.16.0-bin/bin/node_exporter
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v0j3pn7gjrbficw1lmf3x7x8g35n6lvb-node_exporter-0.16.0-bin/bin
patching script interpreter paths in /nix/store/v0j3pn7gjrbficw1lmf3x7x8g35n6lvb-node_exporter-0.16.0-bin
checking for references to /build in /nix/store/v0j3pn7gjrbficw1lmf3x7x8g35n6lvb-node_exporter-0.16.0-bin...
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
/nix/store/v0j3pn7gjrbficw1lmf3x7x8g35n6lvb-node_exporter-0.16.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: prometheus-node-exporter

Partial log (click to expand)

find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
find: '/nix/store/p9drmlkibnbs2pn3p49ms8cm941c6h5p-node_exporter-0.16.0': No such file or directory
/nix/store/77w8vg6jr9sdv6p3qy2s00qbh6c0vfl5-node_exporter-0.16.0-bin

lukateras added a commit to serokell/nixpkgs that referenced this pull request Aug 9, 2018
@lukateras
prometheus-node-exporter: work around prometheus/node_exporter#870
fee61ed 
NixOS#44824
lukateras added a commit to serokell/nixpkgs that referenced this pull request Aug 9, 2018
@lukateras
prometheus-node-exporter: work around prometheus/node_exporter#870
c2e46fe 
NixOS#44824
xeji
xeji reviewed Aug 9, 2018
View reviewed changes
pkgs/servers/monitoring/prometheus/node-exporter.nix Outdated

buildGoPackage rec {
buildGo19Package rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment with a reference to the upstream bug ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prometheus-node-exporter

Partial log (click to expand)

/nix/store/v0j3pn7gjrbficw1lmf3x7x8g35n6lvb-node_exporter-0.16.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prometheus-node-exporter

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin
shrinking /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin/bin/node_exporter
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin/bin
patching script interpreter paths in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin
checking for references to /build in /nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin...
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
/nix/store/i40fvv7nam4dszrixvdyjg3pvsf1q6xb-node_exporter-0.16.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: prometheus-node-exporter

Partial log (click to expand)

/nix/store/77w8vg6jr9sdv6p3qy2s00qbh6c0vfl5-node_exporter-0.16.0-bin

@xeji xeji merged commit fc283bd into NixOS:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @GrahamcOfBorg @xeji