Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-okta: init at 0.19.0 #44819

Merged
merged 1 commit into from Aug 11, 2018
Merged

aws-okta: init at 0.19.0 #44819

merged 1 commit into from Aug 11, 2018

Conversation

imalsogreg
Copy link
Contributor

Motivation for this change

Adding a useful tool for people that need to use Okta for AWS cli access. This package could also be used later in an okta-aws nixos module if we want to provide a less imperative okta login.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Aug 9, 2018

@GrahamcOfBorg build aws-okta

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-okta

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qd6xb46hl32q946mi60z2d1wk01yykfl-aws-okta-0.19.0-bin
shrinking /nix/store/qd6xb46hl32q946mi60z2d1wk01yykfl-aws-okta-0.19.0-bin/bin/aws-okta
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qd6xb46hl32q946mi60z2d1wk01yykfl-aws-okta-0.19.0-bin/bin
patching script interpreter paths in /nix/store/qd6xb46hl32q946mi60z2d1wk01yykfl-aws-okta-0.19.0-bin
checking for references to /build in /nix/store/qd6xb46hl32q946mi60z2d1wk01yykfl-aws-okta-0.19.0-bin...
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
/nix/store/qd6xb46hl32q946mi60z2d1wk01yykfl-aws-okta-0.19.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-okta

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/62nygfrxpvd99xxwsgpydr7g3x8jbq44-aws-okta-0.19.0-bin
shrinking /nix/store/62nygfrxpvd99xxwsgpydr7g3x8jbq44-aws-okta-0.19.0-bin/bin/aws-okta
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/62nygfrxpvd99xxwsgpydr7g3x8jbq44-aws-okta-0.19.0-bin/bin
patching script interpreter paths in /nix/store/62nygfrxpvd99xxwsgpydr7g3x8jbq44-aws-okta-0.19.0-bin
checking for references to /build in /nix/store/62nygfrxpvd99xxwsgpydr7g3x8jbq44-aws-okta-0.19.0-bin...
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
/nix/store/62nygfrxpvd99xxwsgpydr7g3x8jbq44-aws-okta-0.19.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: aws-okta

Partial log (click to expand)

find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
find: '/nix/store/1fhqwwahc2iz9025kvnmrwdnh8gkqdm4-aws-okta-0.19.0': No such file or directory
/nix/store/1y6zp6jnaiy8d03ncfaqva5366np70h0-aws-okta-0.19.0-bin

@imalsogreg
Copy link
Contributor Author

One issue with this PR - the size of the vendor directory in the github checkout is 8Mb. It might be better to use a fork of the aws-okta repository that doesn't include vendor, and to use goDeps to manage the dependencies?

@srhb
Copy link
Contributor

srhb commented Aug 10, 2018

@imalsogreg I don't think we should fork it. We can always nuke the vendor directory during the build. Trying to find someone with the know-how on when and when not to unvendor. :)

@srhb
Copy link
Contributor

srhb commented Aug 10, 2018

#nixos (two data points, so obviously representative) says vendoring is fine, so if you'll just get rid of the comments, we can go ahead and merge. :)

@imalsogreg
Copy link
Contributor Author

@GrahamcOfBorg build aws-okta

@imalsogreg
Copy link
Contributor Author

I force-pushed a commit to my PR branch that removes the unneeded comment and extra meta field.

@srhb
Copy link
Contributor

srhb commented Aug 10, 2018

@GrahamcOfBorg build aws-okta
(It requires special privileges)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-okta

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kpk5zw1lxmg92kgns2g420y51xpw6x6l-aws-okta-0.19.0-bin
shrinking /nix/store/kpk5zw1lxmg92kgns2g420y51xpw6x6l-aws-okta-0.19.0-bin/bin/aws-okta
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kpk5zw1lxmg92kgns2g420y51xpw6x6l-aws-okta-0.19.0-bin/bin
patching script interpreter paths in /nix/store/kpk5zw1lxmg92kgns2g420y51xpw6x6l-aws-okta-0.19.0-bin
checking for references to /build in /nix/store/kpk5zw1lxmg92kgns2g420y51xpw6x6l-aws-okta-0.19.0-bin...
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
/nix/store/kpk5zw1lxmg92kgns2g420y51xpw6x6l-aws-okta-0.19.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-okta

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dcmzy464kj6hjhcyc3hvn4lqhzgc3h75-aws-okta-0.19.0-bin
shrinking /nix/store/dcmzy464kj6hjhcyc3hvn4lqhzgc3h75-aws-okta-0.19.0-bin/bin/aws-okta
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dcmzy464kj6hjhcyc3hvn4lqhzgc3h75-aws-okta-0.19.0-bin/bin
patching script interpreter paths in /nix/store/dcmzy464kj6hjhcyc3hvn4lqhzgc3h75-aws-okta-0.19.0-bin
checking for references to /build in /nix/store/dcmzy464kj6hjhcyc3hvn4lqhzgc3h75-aws-okta-0.19.0-bin...
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
/nix/store/dcmzy464kj6hjhcyc3hvn4lqhzgc3h75-aws-okta-0.19.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: aws-okta

Partial log (click to expand)

find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
find: '/nix/store/zyq3i32f5grf4h1bh5whdx847zgzlq05-aws-okta-0.19.0': No such file or directory
/nix/store/i216gnfrm4pvp70jh65dj2dlm1l2phib-aws-okta-0.19.0-bin

@srhb srhb merged commit b92956d into NixOS:master Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imalsogreg @srhb @GrahamcOfBorg