Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

img2pdf init at 0.3.1 #44833

Merged
merged 2 commits into from Aug 9, 2018
Merged

img2pdf init at 0.3.1 #44833

merged 2 commits into from Aug 9, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Aug 9, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: img2pdf, pdftk

Partial log (click to expand)

/build/img2pdf-0.3.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1/lib  /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1/bin
patching script interpreter paths in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1
checking for references to /build in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1...
wrapping `/nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1/bin/img2pdf'...
/nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1
/nix/store/y2h57abqcf4i738hplp74d7793vsxrxx-pdftk-2.02

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: img2pdf, pdftk

Partial log (click to expand)

Successfully installed img2pdf-0.3.1
/build/img2pdf-0.3.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1/lib  /nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1/bin
patching script interpreter paths in /nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1
checking for references to /build in /nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1...
wrapping `/nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1/bin/img2pdf'...
error: build of '/nix/store/a22cq7xh60i5y99j62krx22xd2w0llgg-pdftk-2.02.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: img2pdf, pdftk

Partial log (click to expand)

make[3]: Leaving directory '/private/tmp/nix-build-gcj-6.4.0.drv-0/build/build-x86_64-apple-darwin/fixincludes'
make[2]: *** [Makefile:2777: all-build-fixincludes] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-gcj-6.4.0.drv-0/build'
make[1]: *** [Makefile:18768: stage1-bubble] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-gcj-6.4.0.drv-0/build'
make: *** [Makefile:19073: bootstrap] Error 2
builder for '/nix/store/l88cyq8rkf5qmarfqxvdmzycf1jis7sq-gcj-6.4.0.drv' failed with exit code 2
cannot build derivation '/nix/store/8dyc6j7qpxj1l0cq13ccfdcv6z50p9bk-gcj-wrapper-6.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/irkyfknwdl9zc8xq40npxj7vv20hbcjh-pdftk-2.02.drv': 2 dependencies couldn't be built
error: build of '/nix/store/irkyfknwdl9zc8xq40npxj7vv20hbcjh-pdftk-2.02.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: img2pdf

Partial log (click to expand)

/nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: img2pdf

Partial log (click to expand)

Successfully installed img2pdf-0.3.1
/build/img2pdf-0.3.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1/lib  /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1/bin
patching script interpreter paths in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1
checking for references to /build in /nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1...
wrapping `/nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1/bin/img2pdf'...
/nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: img2pdf

Partial log (click to expand)

/nix/store/hxdjp4ry8phmr0qngp34jdxgfw6y0n2c-img2pdf-0.3.1

xeji
xeji reviewed Aug 9, 2018
View reviewed changes
pkgs/applications/misc/img2pdf/default.nix Outdated
@@ -0,0 +1,25 @@
{ stdenv, buildPythonApplication, fetchPypi, python3Packages }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ stdenv, python3Packages } is sufficient. You can access the others as python3Packages.fetchPypi and python3Packages.buildPythonApplication.

pkgs/top-level/all-packages.nix Outdated
@@ -16856,6 +16856,10 @@ with pkgs;

inherit (nodePackages) imapnotify;

img2pdf = callPackage ../applications/misc/img2pdf {
inherit (python3Packages) buildPythonApplication fetchPypi;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary if you do as suggested above

xeji
xeji approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it on one of my random photos and it worked 😄

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: img2pdf

Partial log (click to expand)

/nix/store/wf8l2w2m3rp5k1hd8y4rs0yqz8j77799-img2pdf-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: img2pdf

Partial log (click to expand)

/nix/store/c4hsi0811jkln1xmw3gr4dy1p3wflp2q-img2pdf-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: img2pdf

Partial log (click to expand)

  The script img2pdf is installed in '/nix/store/hxdjp4ry8phmr0qngp34jdxgfw6y0n2c-img2pdf-0.3.1/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed img2pdf-0.3.1
/private/tmp/nix-build-img2pdf-0.3.1.drv-0/img2pdf-0.3.1
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxdjp4ry8phmr0qngp34jdxgfw6y0n2c-img2pdf-0.3.1/lib  /nix/store/hxdjp4ry8phmr0qngp34jdxgfw6y0n2c-img2pdf-0.3.1/bin
patching script interpreter paths in /nix/store/hxdjp4ry8phmr0qngp34jdxgfw6y0n2c-img2pdf-0.3.1
wrapping `/nix/store/hxdjp4ry8phmr0qngp34jdxgfw6y0n2c-img2pdf-0.3.1/bin/img2pdf'...
/nix/store/hxdjp4ry8phmr0qngp34jdxgfw6y0n2c-img2pdf-0.3.1

@xeji xeji merged commit fad7857 into NixOS:master Aug 9, 2018
@veprbl veprbl deleted the pr/img2pdf branch December 1, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @xeji