pcre: fetch from HTTPS instead of FTP #44828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not uncommon for enterprise environments to block FTP traffic to external sites. Since `pcre` gives an official HTTPS download URL [1] alongside the official FTP endpoint, let's use that instead. [1] https://www.pcre.org/
bhipple
commented
Aug 9, 2018
| @@ -18,7 +18,7 @@ in stdenv.mkDerivation rec { | |||
| name = "${pname}-${version}"; | |||
|
|
|||
| src = fetchurl { | |||
| url = "ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre/pcre-${version}.tar.bz2"; | |||
| url = "https://ftp.pcre.org/pub/pcre/pcre-${version}.tar.bz2"; | |||
| sha256 = "00ckpzlgyr16bnqx8fawa3afjgqxw5yxgs2l081vw23qi1y4pl1c"; | |||
There was a problem hiding this comment.
$ nix-prefetch-url https://ftp.pcre.org/pub/pcre/pcre-8.42.tar.bz2
00ckpzlgyr16bnqx8fawa3afjgqxw5yxgs2l081vw23qi1y4pl1c
Looks like we should be able to just swap this without doing any rebuilds.
|
@GrahamcOfBorg build pcre |
|
Success on aarch64-linux (full log) Attempted: pcre Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pcre Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: pcre Partial log (click to expand)
|
|
zero rebuilds, LGTM. |
|
Success on aarch64-linux (full log) Attempted: pcre Partial log (click to expand)
|
bhipple
added a commit
to bhipple/nixpkgs
that referenced
this pull request
Aug 23, 2018
Same change as in NixOS#44828, for the same reasons.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not uncommon for enterprise environments to block FTP traffic to external
sites. Since
pcregives an official HTTPS download URL [1] alongside theofficial FTP endpoint, let's use that instead.
[1] https://www.pcre.org/
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)