Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elementary-cmake-modules: add version #43732

Merged
merged 1 commit into from Jul 18, 2018
Merged

elementary-cmake-modules: add version #43732

merged 1 commit into from Jul 18, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Part of #43717

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 18, 2018

Where does the version number come from? I cannot see it in the repo.

@worldofpeace
Copy link
Contributor Author

Here, It's retired software and not used centrally anymore. I would remove it from nixpkgs if some applications weren't depending on it.

@jtojnar
Copy link
Contributor

jtojnar commented Jul 18, 2018

The only depending package is regextester. Maybe we should ask them to port to meson.

@worldofpeace
Copy link
Contributor Author

I believe the author of regextester has been unavailable for several months. But an issue wouldn't hurt in case someone wanted to contribute it. 😉

@xeji
Copy link
Contributor

xeji commented Jul 18, 2018

@GrahamcOfBorg build elementary-cmake-modules

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: elementary-cmake-modules

Partial log (click to expand)

-- Installing: /nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0/lib/cmake/Uninstall.cmake
-- Installing: /nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0/lib/cmake/ValaPrecompile.cmake
-- Installing: /nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0/lib/cmake/ValaVersion.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0/lib
patching script interpreter paths in /nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0
checking for references to /build in /nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0...
/nix/store/25h1crkvm6fk8ss109j7c0rpm3wyp22x-elementary-cmake-modules-0.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: elementary-cmake-modules

Partial log (click to expand)

-- Installing: /nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0/lib/cmake/Tests.cmake
-- Installing: /nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0/lib/cmake/Translations.cmake
-- Installing: /nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0/lib/cmake/Uninstall.cmake
-- Installing: /nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0/lib/cmake/ValaPrecompile.cmake
-- Installing: /nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0/lib/cmake/ValaVersion.cmake
post-installation fixup
strip is /nix/store/8axizw5mf6dx7wip65nbkyrmlkhmjhc5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0/lib
patching script interpreter paths in /nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0
/nix/store/lsx8isfqpickcrgshzgqh8ndi4jfz26p-elementary-cmake-modules-0.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: elementary-cmake-modules

Partial log (click to expand)

-- Installing: /nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0/lib/cmake/Uninstall.cmake
-- Installing: /nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0/lib/cmake/ValaPrecompile.cmake
-- Installing: /nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0/lib/cmake/ValaVersion.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0/lib
patching script interpreter paths in /nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0
checking for references to /build in /nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0...
/nix/store/2ysq58p5bmcljxrg61ajih4rnqbqv1vx-elementary-cmake-modules-0.1.0

@xeji xeji merged commit 3ea1e50 into NixOS:master Jul 18, 2018
@worldofpeace worldofpeace deleted the patch-3 branch July 18, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @xeji @GrahamcOfBorg