Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: Added missing dependency, awk, to kube-addon-manager path #43725

Merged
merged 1 commit into from Jul 18, 2018
Merged

nixos/kubernetes: Added missing dependency, awk, to kube-addon-manager path #43725

merged 1 commit into from Jul 18, 2018

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Jul 18, 2018

fixes #43708

That should do it @azazel75 . Thanks for reporting this! 👍
@srhb Care to review please? :-)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Jul 18, 2018

Do any of our tests expose this?

@johanot
Copy link
Contributor Author

johanot commented Jul 18, 2018 •
edited

@srhb No. The addon manager uses awk for determining whether the controller manager on the current node is leader. https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/addon-manager/kube-addons.sh#L158

Thus, this only applies to muti-master setups.

And if you look at lines 159-164, the addonmanager will ignore that leader determination failed and apply addons anyway.

We would need 1) a multi-master test suite, 2) a way of detecting that addons are applied on non-leaders.
.. but we are not there now/yet.

@srhb srhb merged commit ff49b1e into NixOS:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes: possible missing dependency
2 participants
@johanot @srhb