Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: Don't lose rbac submodule with no explicit options #43728

Merged
merged 1 commit into from Jul 18, 2018
Merged

k8s: Don't lose rbac submodule with no explicit options #43728

merged 1 commit into from Jul 18, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 18, 2018 •
edited

Motivation for this change

Fixes #43726

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb changed the title Don't lose rbac submodule with no explicit options k8s: Don't lose rbac submodule with no explicit options Jul 18, 2018
@srhb
Copy link
Contributor Author

srhb commented Jul 18, 2018

@johanot

❯ nix-build nixos/tests/kubernetes/rbac.nix nixos/tests/kubernetes/dns.nix
/nix/store/l0x0kkq8725ncbibxawnfq8d0hg7rs57-vm-test-run-kubernetes-rbac-multinode
/nix/store/x4g14iym30gk4y12v3gis1v447z85d4z-vm-test-run-kubernetes-rbac-singlenode
/nix/store/0c8qiiz3rcj6bp7jnd604kpr3iqdf0rz-vm-test-run-kubernetes-dns-multinode
/nix/store/27v45ihfv11zdlglk4zxpihqcr1fid3w-vm-test-run-kubernetes-dns-singlenode

@johanot
Copy link
Contributor

johanot commented Jul 18, 2018

@srhb LGTM. Tests rbac and dns run clean on my machine too - using your branch.

@srhb srhb merged commit 5672083 into NixOS:master Jul 18, 2018
@srhb srhb deleted the k8srbacfix branch July 18, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @johanot