Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-index: 0.1.0 -> 0.1.1 #43729

Merged
merged 1 commit into from Jul 19, 2018
Merged

nix-index: 0.1.0 -> 0.1.1 #43729

merged 1 commit into from Jul 19, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 18, 2018 •
edited

Motivation for this change

Specifically for --show-trace passthrough

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from bennofs July 18, 2018 10:57
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nix-index

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1
shrinking /nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1/bin/nix-index
shrinking /nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1/bin/nix-locate
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1/bin
patching script interpreter paths in /nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1
/nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1/etc/profile.d/command-not-found.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1...
/nix/store/zkkcn38m9m75hizzlqyngwnlrb49r96q-nix-index-0.1.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nix-index

Partial log (click to expand)


test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/8axizw5mf6dx7wip65nbkyrmlkhmjhc5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ryr5434ppi5irlymhwin6z030gw5c5jn-nix-index-0.1.1/bin
patching script interpreter paths in /nix/store/ryr5434ppi5irlymhwin6z030gw5c5jn-nix-index-0.1.1
/nix/store/ryr5434ppi5irlymhwin6z030gw5c5jn-nix-index-0.1.1/etc/profile.d/command-not-found.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mdzgfbangzw62b6cb48dg0q83sxdy12y-bash-4.4-p23/bin/sh"
/nix/store/ryr5434ppi5irlymhwin6z030gw5c5jn-nix-index-0.1.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nix-index

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1
shrinking /nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1/bin/nix-locate
shrinking /nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1/bin/nix-index
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1/bin
patching script interpreter paths in /nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1
/nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1/etc/profile.d/command-not-found.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3swzdhnphnbxjcyx2bkk1gh9k8gi3kl6-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1...
/nix/store/jxyk0874xwrqjbzb234mndcwn6i1xgg8-nix-index-0.1.1

infinisil
infinisil approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well

@srhb srhb merged commit 1bec0a9 into NixOS:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @GrahamcOfBorg @infinisil