Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: more fixes to tests #43700

Merged
merged 3 commits into from Jul 23, 2018
Merged

treewide: more fixes to tests #43700

merged 3 commits into from Jul 23, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Jul 17, 2018

Yet another^2 followup to #39464.

matthewbauer
matthewbauer reviewed Jul 18, 2018
View reviewed changes
pkgs/development/libraries/librdf/default.nix
@@ -1,5 +1,6 @@
{ stdenv, fetchurl, pkgconfig, autoreconfHook
, librdf_raptor2, ladspaH, openssl, zlib
, doCheck ? stdenv.config.doCheckByDefault or false, ladspaPlugins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like having this here. Would it be possible to avoid the conditional and always patch like we are potentially going to run the tests?

@oxij
Copy link
Member Author

oxij commented Jul 18, 2018 via email

@matthewbauer
Copy link
Member

Yes, but ladspaPlugins is a pretty heavy thing and I'm trying not to influence build times till there's a consensus of setting doCheckByDefault to true.

Ok that makes sense.

@grahamc
Copy link
Member

grahamc commented Jul 18, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: at-spi2-atk, at-spi2-core, fribidi, libnice, librdf

Partial log (click to expand)

shrinking /nix/store/pcg6h1dnbqkm9acn7d52ai6hqx0vnyrc-liblrdf-0.5.0/lib/liblrdf.so.2.0.0
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pcg6h1dnbqkm9acn7d52ai6hqx0vnyrc-liblrdf-0.5.0/lib
patching script interpreter paths in /nix/store/pcg6h1dnbqkm9acn7d52ai6hqx0vnyrc-liblrdf-0.5.0
checking for references to /build in /nix/store/pcg6h1dnbqkm9acn7d52ai6hqx0vnyrc-liblrdf-0.5.0...
/nix/store/sw01ib2kcc5wfzlir4jjhb9b78b6cfq5-at-spi2-atk-2.26.2
/nix/store/0zzc3y9plkfnv2n3asvph0snkmi383i0-at-spi2-core-2.28.0
/nix/store/gwck3q705ckmhn2bzms0g22dmdi302qn-fribidi-1.0.4
/nix/store/mylyhlbd95j7j3021z9iha0sihpma3fq-libnice-0.1.14
/nix/store/pcg6h1dnbqkm9acn7d52ai6hqx0vnyrc-liblrdf-0.5.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: at-spi2-atk, at-spi2-core, fribidi, libnice, librdf

Partial log (click to expand)

shrinking /nix/store/8h1hwj8n8qj7l14xqqx0wccjrr8zinm5-liblrdf-0.5.0/lib/liblrdf.so.2.0.0
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8h1hwj8n8qj7l14xqqx0wccjrr8zinm5-liblrdf-0.5.0/lib
patching script interpreter paths in /nix/store/8h1hwj8n8qj7l14xqqx0wccjrr8zinm5-liblrdf-0.5.0
checking for references to /build in /nix/store/8h1hwj8n8qj7l14xqqx0wccjrr8zinm5-liblrdf-0.5.0...
/nix/store/9p1pps6g3xbw8ig8ygw86zfjqqd2bjk2-at-spi2-atk-2.26.2
/nix/store/0zcz5wymxc2nnyxqnq6kn5zgqn26vq83-at-spi2-core-2.28.0
/nix/store/jqybygz1k9by0pz099bg2xprd0rp5j19-fribidi-1.0.4
/nix/store/5l36vk8625qmh77mg7g7jg13zczd9dda-libnice-0.1.14
/nix/store/8h1hwj8n8qj7l14xqqx0wccjrr8zinm5-liblrdf-0.5.0

@matthewbauer matthewbauer merged commit 856743f into NixOS:master Jul 23, 2018
@oxij oxij deleted the tree/more-test-fixes branch November 18, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxij @matthewbauer @grahamc @GrahamcOfBorg