Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fastpair: init at 2016-07-05 #43722

Merged
merged 1 commit into from Jul 31, 2018
Merged

pythonPackages.fastpair: init at 2016-07-05 #43722

merged 1 commit into from Jul 31, 2018

Conversation

CMCDragonkai
Copy link
Member

Motivation for this change

Added python package fastpair. However this does not have a version as it is not released on PyPi.

So I used the date of the last commit as the version. I hope that is correct.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@CMCDragonkai CMCDragonkai requested a review from FRidh as a code owner July 18, 2018 07:56
FRidh
FRidh requested changes Jul 18, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I used the date of the last commit as the version. I hope that is correct.

That's good.

pkgs/development/python-modules/fastpair/default.nix
sha256 = "1pv9sxycxdk567s5gs947rhlqngrb9nn9yh4dhdvg1ix1i8dca71";
};

buildInputs = [ pytestrunner ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkInputs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of setup_requires.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh What do you think?

FRidh
FRidh reviewed Jul 18, 2018
View reviewed changes
pkgs/development/python-modules/fastpair/default.nix Outdated
checkPhase = ''
py.test fastpair
'';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta is missing, including maintainership

@CMCDragonkai
Copy link
Member Author

Added everything.

@FRidh
Copy link
Member

FRidh commented Jul 18, 2018

@GrahamcOfBorg build pythonPackages.fastpair python3Packages.fastpair

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.fastpair, python3Packages.fastpair

Partial log (click to expand)

collected 12 items

fastpair/test/test_fastpair.py ............                              [100%]

========================== 12 passed in 8.21 seconds ===========================
fastpair/test/test_fastpair.py ............                              [100%]

========================== 12 passed in 10.92 seconds ==========================
/nix/store/a93m1sxpab54cdmxpnv1qsqnz40nk5r9-python2.7-fastpair-2016-07-05
/nix/store/prc4r8va8v8fhqa8sqx89x0kksca8vhk-python3.6-fastpair-2016-07-05

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.fastpair, python3Packages.fastpair

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.6, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 12 items

fastpair/test/test_fastpair.py ............                              [100%]

========================== 12 passed in 5.65 seconds ===========================
/nix/store/1mf4ha9m212wn4zb1m3l0q1402wip8ns-python2.7-fastpair-2016-07-05
/nix/store/yd6is3glfcmgk1r1mss14jzsni7fw38v-python3.6-fastpair-2016-07-05

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.fastpair, python3Packages.fastpair

Partial log (click to expand)

============================= test session starts ==============================
platform darwin -- Python 3.6.6, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /private/tmp/nix-build-python3.6-fastpair-2016-07-05.drv-0/source, inifile:
collected 12 items

fastpair/test/test_fastpair.py ............                              [100%]

========================== 12 passed in 1.48 seconds ===========================
/nix/store/0bscnallykn0f6myxhqmk3964zrn3bzb-python2.7-fastpair-2016-07-05
/nix/store/xd0mj5alihnbs3ib4j5jdkiyxmpnrh8b-python3.6-fastpair-2016-07-05

@CMCDragonkai
Copy link
Member Author

Fixed licenses to license.

@CMCDragonkai
Copy link
Member Author

@FRidh Is this ready to be merged?

@dotlambda dotlambda merged commit 0f70e78 into NixOS:master Jul 31, 2018
@CMCDragonkai CMCDragonkai deleted the fastpair branch August 8, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CMCDragonkai @FRidh @GrahamcOfBorg @dotlambda