Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntl: darwin support #44995

Merged
merged 2 commits into from Aug 13, 2018
Merged

ntl: darwin support #44995

merged 2 commits into from Aug 13, 2018

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Aug 13, 2018

Motivation for this change

Allow ntl to build on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Aug 13, 2018
@jbaum98 jbaum98 changed the title ntl darwin support ntl: darwin support Aug 13, 2018
@vcunat
Copy link
Member

vcunat commented Aug 13, 2018

@GrahamcOfBorg build ntl

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ntl

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@vcunat
Copy link
Member

vcunat commented Aug 13, 2018 •
edited

gf2x-1.2 needs fixing its meta.platforms or something, and possibly other dependencies.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ntl

Partial log (click to expand)

more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1
shrinking /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1/lib/libntl.so.38.0.0
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1/lib
patching script interpreter paths in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1
checking for references to /build in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1...
/nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1

@jbaum98
Copy link
Contributor Author

jbaum98 commented Aug 13, 2018

Oh sorry, I have allowUnsupportedSystems = true, I'll unset that and fix.

@jbaum98
Copy link
Contributor Author

jbaum98 commented Aug 13, 2018

Seems that gf2x was the only one, now builds for me without allowUnsupportedSystems.

@vcunat
Copy link
Member

vcunat commented Aug 13, 2018

@GrahamcOfBorg build ntl

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ntl

Partial log (click to expand)

more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kgly1rzyvfg25gdlqrgsgzqdpajighd1-ntl-11.2.1
shrinking /nix/store/kgly1rzyvfg25gdlqrgsgzqdpajighd1-ntl-11.2.1/lib/libntl.so.38.0.0
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kgly1rzyvfg25gdlqrgsgzqdpajighd1-ntl-11.2.1/lib
patching script interpreter paths in /nix/store/kgly1rzyvfg25gdlqrgsgzqdpajighd1-ntl-11.2.1
checking for references to /build in /nix/store/kgly1rzyvfg25gdlqrgsgzqdpajighd1-ntl-11.2.1...
/nix/store/kgly1rzyvfg25gdlqrgsgzqdpajighd1-ntl-11.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ntl

Partial log (click to expand)

these derivations will be built:
  /nix/store/lxhmv4aaixdzhh1k4y1sw165icah5rh3-ntl-11.2.1.drv
waiting for locks or build slots...
/nix/store/kgly1rzyvfg25gdlqrgsgzqdpajighd1-ntl-11.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ntl

Partial log (click to expand)

more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1
shrinking /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1/lib/libntl.so.38.0.0
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1/lib
patching script interpreter paths in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1
checking for references to /build in /nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1...
/nix/store/drh3kg93fap416k2xb4v1b1xi5hlvkb3-ntl-11.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ntl

Partial log (click to expand)

libtool: install: (cd /nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1/lib && { ln -s -f libntl.38.dylib libntl.dylib || { rm -f libntl.dylib && ln -s libntl.38.dylib libntl.dylib; }; })
libtool: install: cp -p .libs/libntl.lai /nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1/lib/libntl.la
libtool: install: cp -p .libs/libntl.a /nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1/lib/libntl.a
libtool: install: chmod 644 /nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1/lib/libntl.a
libtool: install: ranlib /nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1/lib/libntl.a
post-installation fixup
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1/lib
patching script interpreter paths in /nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1
/nix/store/9dzfq61jap3vfrx5hbvbby0n1wppxf2q-ntl-11.2.1

vcunat
vcunat approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK, probably no use to wait.

@vcunat vcunat merged commit 42a0d36 into NixOS:master Aug 13, 2018
@jbaum98 jbaum98 deleted the ntl-darwin branch August 13, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jbaum98 @vcunat @GrahamcOfBorg @globin @timokau @victorshoup