buildRustPackage: allow patches to fix Cargo.lock #44981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Did you verify with |
|
Maybe document cargoPatches in doc/languages-frameworks/rust.section.md ? |
|
@LnL7 I don't know how to verify with @symphorien Good point, done! |
Mic92
reviewed
Aug 14, 2018
| @@ -59,6 +59,10 @@ all crate sources of this package. Currently it is obtained by inserting a | |||
| fake checksum into the expression and building the package once. The correct | |||
| checksum can be then take from the failed build. | |||
|
|
|||
| When there is an error in the `Cargo.lock` provided by upstream, it is possible | |||
There was a problem hiding this comment.
When the `Cargo.lock` file, provided by upstream, is not in sync with the `Cargo.toml` it is possible to use `cargoPatches` to update it.
Mic92
reviewed
Aug 14, 2018
| @@ -59,6 +59,10 @@ all crate sources of this package. Currently it is obtained by inserting a | |||
| fake checksum into the expression and building the package once. The correct | |||
| checksum can be then take from the failed build. | |||
|
|
|||
| When there is an error in the `Cargo.lock` provided by upstream, it is possible | |||
| to use `cargoPatches` to fix this up. All patches added in `cargoPatches` will | |||
| also be prepended to the patches in `patches` for build-time. | |||
|
Thanks! fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version that should work of #44967
I have checked building a package that requires it (#44968) and a project that uses dynamic patches (
rustracer).rustracer's hashes appear to not have changed, so I guess it's alright :)cc @Mic92 @LnL7
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)