yarn: add yarnpkg bin alias output #44133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jul 28, 2018
| @@ -15,6 +15,7 @@ stdenv.mkDerivation rec { | |||
| mkdir -p $out/{bin,libexec/yarn/} | |||
| cp -R . $out/libexec/yarn | |||
| makeWrapper $out/libexec/yarn/bin/yarn.js $out/bin/yarn | |||
| makeWrapper $out/libexec/yarn/bin/yarn.js $out/bin/yarnpkg | |||
There was a problem hiding this comment.
Would symlinks work for both cases?
|
I am thinking we should just move to using |
|
cc @offlinehacker who added this package in the first place. |
|
@matthewbauer I agree, and I tried to make that change earlier in the year (#35063). Updated to simply symlink. The wrappers work fine, but I don't see why they'd be necessary. |
|
Ok, sorry hadn't seen that. For now this seems fine then. We probably want to fix the nodePackages thing though so that patches work correctly. |
matthewbauer
approved these changes
Jul 30, 2018
Because the hadoop project also provides a binary `yarn`, the yarn project [added this alias to help people with both hadoop and yarn installed](yarnpkg/yarn#673 (comment)). Some scripts in the wild use this alias for the same reason.
|
Updated to fix merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Because the hadoop project also provides a binary
yarn, the yarn project added this alias to help people with both hadoop and yarn installed. Some scripts in the wild use this alias for the same reason.With this change, those scripts are usable with the nixpkgs yarn package.
Things done
sandboxinnix.confon non-NixOS)[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)