Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kicad: 4.0.7 -> 5.0.0 #44122

Merged
merged 3 commits into from Jul 31, 2018
Merged

kicad: 4.0.7 -> 5.0.0 #44122

merged 3 commits into from Jul 31, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Jul 26, 2018

Motivation for this change

Just a regular update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bgamari bgamari mentioned this pull request Jul 26, 2018
Closed
@bgamari
Copy link
Contributor Author

bgamari commented Jul 26, 2018 •
edited

Note that I have been unable to test the OpenGL canvas due to apparent OpenGL brokenness in nixpkgs master. (#44057).

@brodul
Copy link
Contributor

brodul commented Jul 26, 2018

@bgamari title needs change. The upgrade is from 4.0.7 to 5.0.0

@brodul
Copy link
Contributor

brodul commented Jul 26, 2018

I tried to install the package:

trying https://code.launchpad.net/kicad/5/5.0.0/+download/kicad-5.0.0.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download kicad-5.0.0.tar.xz from any mirror

@brodul
Copy link
Contributor

brodul commented Jul 26, 2018

Tnx for you work. 🍻

@bgamari bgamari changed the title kicad: 0.4.7 -> 0.5.0 kicad: 4.0.7 -> 0.5.0 Jul 26, 2018
@brodul
Copy link
Contributor

brodul commented Jul 29, 2018

Now it builds. There is an error when pcbnew is launched.

10:32:32 AM: Python error -1 occurred running string `import wxversion;  wxversion.select('3.0')`
10:32:32 AM: pcbnewInitPythonScripting() failed.

OpenGL works fine.

Mic92
Mic92 reviewed Jul 29, 2018
View reviewed changes
pkgs/applications/science/electronics/kicad/default.nix
license = stdenv.lib.licenses.gpl2;
maintainers = with stdenv.lib.maintainers; [viric];
platforms = with stdenv.lib.platforms; linux;
hydraPlatforms = []; # 'output limit exceeded' error on hydra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the package size reduced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear; can we get a test build to find out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is 55mb large. This is fine.

@Mic92 Mic92 changed the title kicad: 4.0.7 -> 0.5.0 kicad: 4.0.7 -> 5.0.0 Jul 30, 2018
Mic92
Mic92 reviewed Jul 31, 2018
View reviewed changes
pkgs/applications/science/electronics/kicad/default.nix
, wrapGAppsHook
, oceSupport ? true, opencascade
, ngspiceSupport ? true, libngspice
, swig, python, pythonPackages
Copy link
Member

@Mic92 Mic92 Jul 31, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the parameter scriptingSupport for simplicity. If somebody really needs, it can be restored.

@Mic92 Mic92 merged commit 9cff865 into NixOS:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @brodul @Mic92 @GrahamcOfBorg