Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli53: 0.4.4 -> 0.8.12 #44130

Merged
merged 1 commit into from Aug 20, 2018
Merged

cli53: 0.4.4 -> 0.8.12 #44130

merged 1 commit into from Aug 20, 2018

Conversation

cransom
Copy link
Contributor

@cransom cransom commented Jul 26, 2018

This is bigger change than the version would imply as the author has
rewritten in Go and no longer supports the Python app.

0.8.8 was merged previously, but reverted by @domenkozar but I didn't see any issues/commit comments on the revert, so I don't know why it was removed.

Motivation for this change

The older version is no longer supported and I'm looking to manage newer entries (CAA records) that the python variant doesn't support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Jul 28, 2018
View reviewed changes
pkgs/tools/admin/cli53/default.nix Outdated
src = fetchgit {
rev = "2624c7c4b38a33cdbd166dad1d3e512830f453e4";
url = "https://github.com/barnybug/cli53.git";
sha256 = "0bhczmzrgf7ypnhhzdrgnvg8cw8ch1x1d0cgajc5kklq9ixv9ygi";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there seems to be no git submodules in this project, fetchFromGitHub is the preferred method.

cli53: 0.4.4 -> 0.8.12
27d4088 
This is bigger change than the version would imply as the author has
rewritten in Go and no longer supports the Python app.
@xeji
Copy link
Contributor

xeji commented Aug 19, 2018

@GrahamcOfBorg buidl cli53

@xeji
Copy link
Contributor

xeji commented Aug 19, 2018

@GrahamcOfBorg build cli53

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cli53

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q5i96gxxnxcix65cr0bjv9g3ml6x6dyl-cli53-0.8.12-bin
shrinking /nix/store/q5i96gxxnxcix65cr0bjv9g3ml6x6dyl-cli53-0.8.12-bin/bin/cli53
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q5i96gxxnxcix65cr0bjv9g3ml6x6dyl-cli53-0.8.12-bin/bin
patching script interpreter paths in /nix/store/q5i96gxxnxcix65cr0bjv9g3ml6x6dyl-cli53-0.8.12-bin
checking for references to /build in /nix/store/q5i96gxxnxcix65cr0bjv9g3ml6x6dyl-cli53-0.8.12-bin...
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
/nix/store/q5i96gxxnxcix65cr0bjv9g3ml6x6dyl-cli53-0.8.12-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cli53

Partial log (click to expand)

find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
find: '/nix/store/lvvjiixrv07g1gc63a696m21lq0sw82c-cli53-0.8.12': No such file or directory
/nix/store/kxw3xn8mimm9m56phm8hl0mpskdar2az-cli53-0.8.12-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cli53

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rzkh45wmkzkz6bckdfxw2ffvl7pm98v6-cli53-0.8.12-bin
shrinking /nix/store/rzkh45wmkzkz6bckdfxw2ffvl7pm98v6-cli53-0.8.12-bin/bin/cli53
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rzkh45wmkzkz6bckdfxw2ffvl7pm98v6-cli53-0.8.12-bin/bin
patching script interpreter paths in /nix/store/rzkh45wmkzkz6bckdfxw2ffvl7pm98v6-cli53-0.8.12-bin
checking for references to /build in /nix/store/rzkh45wmkzkz6bckdfxw2ffvl7pm98v6-cli53-0.8.12-bin...
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
/nix/store/rzkh45wmkzkz6bckdfxw2ffvl7pm98v6-cli53-0.8.12-bin

@Mic92 Mic92 merged commit 74d932d into NixOS:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cransom @xeji @GrahamcOfBorg @Mic92