Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/metrics: drop requiredSystemFeatures #44131

Merged
merged 1 commit into from Jul 27, 2018

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Jul 26, 2018

Lack of a "benchmark" machine on Hydra prevents it from building, and that blocks channels.

/cc @grahamc, @domenkozar. This is just a quick fix. I could set up a spare core2duo machine for this later, for example.

Lack of a "benchmark" machine on Hydra prevents it from building,
and that blocks channels.
@vcunat vcunat added 1.severity: blocker 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 26, 2018
@vcunat vcunat requested a review from edolstra July 26, 2018 16:36
@vcunat
Copy link
Member Author

vcunat commented Jul 26, 2018

If no objections appear, I'm planning to merge in ~24h. The last "nixos-unstable" bump will be about two weeks old at that point.

@domenkozar
Copy link
Member

Won't that make graphs unreliable? Maybe the performance machine also has jobs=1?

@vcunat
Copy link
Member Author

vcunat commented Jul 26, 2018

AFAIK we have no single-job machine available ATM. The rackspace ones are gone, I believe. EDIT: more to the point – running this job on a single-job machine meant for huge builds would seem quite a waste...

@vcunat
Copy link
Member Author

vcunat commented Jul 27, 2018

We agreed to set up a weak machine with "benchmark", but that doesn't change (short-term) plans for this PR from my point of view.

@vcunat vcunat merged commit 1d0caa7 into NixOS:master Jul 27, 2018
@vcunat vcunat deleted the p/metrics-unblock branch July 31, 2018 14:45
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants