pari: 2.9.5 -> 2.11.0 #44129

timokau · 2018-07-26T14:54:24Z

The pari update in #43924 breaks the giac test suite. Jeroen from sagemath analyzed that test failure here and determined that it doesn't actually make any difference to giac. So here I'm applying the upgrade and disabling the relevant test(-set).

Closes #43924. @FRidh

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

timokau · 2018-07-26T14:54:39Z

@GrahamcOfBorg build giac

GrahamcOfBorg · 2018-07-26T14:55:02Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: giac

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

FRidh · 2018-07-26T14:57:45Z

cc @symphorien

GrahamcOfBorg · 2018-07-26T15:02:54Z

Success on x86_64-linux (full log)

Attempted: giac

Partial log (click to expand)

strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7ld77v2nhjyf21513drysaimfk7lg0jr-giac-1.4.9-59/lib  /nix/store/7ld77v2nhjyf21513drysaimfk7lg0jr-giac-1.4.9-59/bin
patching script interpreter paths in /nix/store/7ld77v2nhjyf21513drysaimfk7lg0jr-giac-1.4.9-59
/nix/store/7ld77v2nhjyf21513drysaimfk7lg0jr-giac-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/814lpj8pm3y5zfm6z68qr7bmdfxssbpz-perl-5.24.4/bin/perl"
checking for references to /build in /nix/store/7ld77v2nhjyf21513drysaimfk7lg0jr-giac-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/pibf3va5hjsqmz98di3jk934msqlym5q-giac-1.4.9-59-doc
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/pibf3va5hjsqmz98di3jk934msqlym5q-giac-1.4.9-59-doc
checking for references to /build in /nix/store/pibf3va5hjsqmz98di3jk934msqlym5q-giac-1.4.9-59-doc...
/nix/store/7ld77v2nhjyf21513drysaimfk7lg0jr-giac-1.4.9-59

GrahamcOfBorg · 2018-07-26T15:09:34Z

Success on aarch64-linux (full log)

Attempted: pari

Partial log (click to expand)

these derivations will be built:
  /nix/store/zb67wsh3l6h0hrgf3v5a5yl69wqnys74-pari-2.11.0.drv
waiting for locks or build slots...
/nix/store/k5z1mi1140kfrdsgkq2c5y63gjf4b7rn-pari-2.11.0

GrahamcOfBorg · 2018-07-26T15:12:23Z

Success on x86_64-darwin (full log)

Attempted: pari

Partial log (click to expand)

if test -n "../src/funclist"; then         mkdir -p "/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/pari"/PARI;     ../config/install -m 644 ../src/desc/PARI/822.pm "/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/pari"/PARI;     ../config/install -m 644 ../src/desc/pari.desc "/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/pari"; fi
if test -d ../data; then cd ../data;       for d in `ls`; do         mkdir -p "/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/pari"/$d &&             for f in `ls $d`; do              ../config/install -m 644 $d/$f "/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/pari"/$d;       done >/dev/null;      done;         fi
make[1]: Leaving directory '/private/tmp/nix-build-pari-2.11.0.drv-0/pari-2.11.0/Odarwin-x86_64'
post-installation fixup
gzipping man pages under /nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/man/
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/lib  /nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/bin
patching script interpreter paths in /nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0
/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/pari/misc/gpflog: interpreter directive changed from "/bin/sh" to "/nix/store/ryb1pmpqm7xiznq5574lifykqrr30hg6-bash-4.4-p23/bin/sh"
/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0/share/pari/misc/xgp: interpreter directive changed from "/bin/sh" to "/nix/store/ryb1pmpqm7xiznq5574lifykqrr30hg6-bash-4.4-p23/bin/sh"

GrahamcOfBorg · 2018-07-26T15:17:33Z

Success on aarch64-linux (full log)

Attempted: giac

Partial log (click to expand)

strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0sgbw3q5wly7v1xyq5x5lamnz4dxfhfy-giac-1.4.9-59/lib  /nix/store/0sgbw3q5wly7v1xyq5x5lamnz4dxfhfy-giac-1.4.9-59/bin
patching script interpreter paths in /nix/store/0sgbw3q5wly7v1xyq5x5lamnz4dxfhfy-giac-1.4.9-59
/nix/store/0sgbw3q5wly7v1xyq5x5lamnz4dxfhfy-giac-1.4.9-59/bin/pgiac: interpreter directive changed from "/usr/bin/perl" to "/nix/store/q1xl02dd3f32hlcfnmbmyaypwpj53qrw-perl-5.24.4/bin/perl"
checking for references to /build in /nix/store/0sgbw3q5wly7v1xyq5x5lamnz4dxfhfy-giac-1.4.9-59...
shrinking RPATHs of ELF executables and libraries in /nix/store/pw1r74djap825dfgxpvz2c59gqz5jl64-giac-1.4.9-59-doc
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/pw1r74djap825dfgxpvz2c59gqz5jl64-giac-1.4.9-59-doc
checking for references to /build in /nix/store/pw1r74djap825dfgxpvz2c59gqz5jl64-giac-1.4.9-59-doc...
/nix/store/0sgbw3q5wly7v1xyq5x5lamnz4dxfhfy-giac-1.4.9-59

GrahamcOfBorg · 2018-07-26T15:21:23Z

Success on x86_64-linux (full log)

Attempted: pari

Partial log (click to expand)

shrinking /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/lib/libpari-gmp-tls.so.2.11.0
shrinking /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/bin/gp-2.11
gzipping man pages under /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/share/man/
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/lib  /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/bin
patching script interpreter paths in /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0
/nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/share/pari/misc/xgp: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
/nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/share/pari/misc/gpflog: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0...
/nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0

The pari update makes it necessary to disable a giac test that only fails because it directly tests the pari interface.

timokau · 2018-07-26T16:42:40Z

I've added a link to the report upstream.

GrahamcOfBorg · 2018-07-26T16:54:49Z

Success on x86_64-darwin (full log)

Attempted: pari

Partial log (click to expand)

/nix/store/pf090pf4xi7diqpkgc1bzj8rz8cpk64x-pari-2.11.0

GrahamcOfBorg · 2018-07-26T16:55:08Z

Success on aarch64-linux (full log)

Attempted: pari

Partial log (click to expand)

/nix/store/k5z1mi1140kfrdsgkq2c5y63gjf4b7rn-pari-2.11.0

GrahamcOfBorg · 2018-07-26T16:57:57Z

Success on x86_64-linux (full log)

Attempted: pari

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0
shrinking /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/lib/libpari-gmp-tls.so.2.11.0
shrinking /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/bin/gp-2.11
gzipping man pages under /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/share/man/
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/lib  /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/bin
patching script interpreter paths in /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0
/nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/share/pari/misc/xgp: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
/nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0/share/pari/misc/gpflog: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ljkbjzi4w0nlj5q8xvpnz3jbsczzgrc1-pari-2.11.0...

symphorien · 2018-07-26T19:08:12Z

@timokau I am still waiting for my giac forum account to be approved (I have requested it last year) so Apparently the forum is dead: https://xcas.univ-grenoble-alpes.fr/forum/viewtopic.php?f=8&t=2071

timokau · 2018-07-26T22:01:03Z

At least the admin still posted there this month and somebody who is apparently more involved in giac development did report the bug for me: https://xcas.univ-grenoble-alpes.fr/forum/viewtopic.php?f=4&t=2102#p10326

So does this have your "LGTM" @symphorien?

symphorien · 2018-07-26T22:14:24Z

technically the test failure does not seem spurious, if my understanding is correct, so silencing it seems somewhat wrong.
Unfortunately this is all way beyond my skills to fix, so it is easy for me to complain that a better solution should be found.

symphorien · 2018-07-26T23:14:45Z

So I reread the tests and threads more carefully and the failure is indeed spurious.
So I give you my LGTM label :)

timokau · 2018-07-27T09:44:19Z

Yes its just testing an unused part of the pari interface and that interface changed a bit.

Its not optimal to disable the entire test set, but I think it should be okay for one release (hoping that they fix it soon).

Great! Can someone merge then?

timokau · 2018-07-27T10:41:01Z

@symphorien in case you still want a forum account, this is relevant: https://trac.sagemath.org/ticket/25567#comment:46

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Jul 26, 2018

pari: 2.9.5 -> 2.11.0

330c501

The pari update makes it necessary to disable a giac test that only fails because it directly tests the pari interface.

timokau force-pushed the pari-2.11.0 branch from 82970e1 to 330c501 Compare July 26, 2018 16:42

FRidh merged commit 1fe2a0f into NixOS:master Jul 27, 2018

timokau deleted the pari-2.11.0 branch July 27, 2018 10:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pari: 2.9.5 -> 2.11.0 #44129

pari: 2.9.5 -> 2.11.0 #44129

timokau commented Jul 26, 2018

timokau commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

FRidh commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

timokau commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

symphorien commented Jul 26, 2018

timokau commented Jul 26, 2018

symphorien commented Jul 26, 2018

symphorien commented Jul 26, 2018

timokau commented Jul 27, 2018

timokau commented Jul 27, 2018

pari: 2.9.5 -> 2.11.0 #44129

pari: 2.9.5 -> 2.11.0 #44129

Conversation

timokau commented Jul 26, 2018

Motivation for this change

Things done

timokau commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

FRidh commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

timokau commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

GrahamcOfBorg commented Jul 26, 2018

symphorien commented Jul 26, 2018

timokau commented Jul 26, 2018

symphorien commented Jul 26, 2018

symphorien commented Jul 26, 2018

timokau commented Jul 27, 2018

timokau commented Jul 27, 2018