Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 67.0.3396.99 -> 68.0.3440.75 #44132

Merged
merged 1 commit into from Jul 27, 2018
Merged

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Jul 26, 2018

Motivation for this change

New major stable release is out and contains 42 security fixes as well as ton of new features.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I've checked that stable branch builds, didn't check beta branch as it lags behind stable at this moment. Dev is broken due to work done to extract gn code out of Chromium (we could get another build speedup by building it separately, yay!), we'll need to figure it out separately.


CC @bendlas @7c6f434c

@bendlas
Copy link
Contributor

bendlas commented Jul 27, 2018

Thanks!

@bendlas bendlas merged commit cd3283f into NixOS:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants