Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: Enable mysqlnd as default #44117

Merged
merged 1 commit into from Jul 27, 2018
Merged

php: Enable mysqlnd as default #44117

merged 1 commit into from Jul 27, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 26, 2018 •
edited

Motivation for this change

MySQL Native Driver was implemented by PHP back in 5.3.0 and has been
default in most distributions for a very long time.

The option was added in 41cd4f2 and I don't see any reason why it would default to false.

Overview of mysqlnd by PHP: https://secure.php.net/manual/en/mysqlnd.overview.php

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @globin @FRidh @adisbladis @srhb @elitak @talyz

@etu
Copy link
Contributor Author

etu commented Jul 26, 2018

@GrahamcOfBorg build php56 php70 php71

@etu
php: Enable mysqlnd as default
1c71785 
MySQL Native Driver was implemented by PHP back in 5.3.0 and has been
default in most distributions for a very long time.

The option was added in 41cd4f2 and I
don't see any reason why it would default to false.

Overview of mysqlnd by PHP: https://secure.php.net/manual/en/mysqlnd.overview.php
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php56, php70, php71

Partial log (click to expand)

/nix/store/c81b8ch46cdzmx707dnfn3nnf231r82p-php-7.1.19/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/c81b8ch46cdzmx707dnfn3nnf231r82p-php-7.1.19...
moving /nix/store/c81b8ch46cdzmx707dnfn3nnf231r82p-php-7.1.19/sbin/* to /nix/store/c81b8ch46cdzmx707dnfn3nnf231r82p-php-7.1.19/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/mpxbzzr41xflnii2r5lwap0bbcvg8bvw-php-7.1.19-dev
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/mpxbzzr41xflnii2r5lwap0bbcvg8bvw-php-7.1.19-dev
checking for references to /build in /nix/store/mpxbzzr41xflnii2r5lwap0bbcvg8bvw-php-7.1.19-dev...
/nix/store/b34n5ak3xffiq8cvpzi6qzbmip16r3g1-php-5.6.36
/nix/store/6q70yl0igb9aspdnbmh43pfi23ax10pz-php-7.0.30
/nix/store/c81b8ch46cdzmx707dnfn3nnf231r82p-php-7.1.19

@etu
Copy link
Contributor Author

etu commented Jul 26, 2018

I thought that the bot would build php72 as well since that's the default php. But it doesn't seem like it.

@GrahamcOfBorg build php72

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php56, php70, php71

Partial log (click to expand)

/nix/store/q5m62m2k2jqcc21p5qsb36n7l5a5zcs8-php-7.1.19/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/n86k15k75jfjqx7k4lzprj055pm7ssjn-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/q5m62m2k2jqcc21p5qsb36n7l5a5zcs8-php-7.1.19...
moving /nix/store/q5m62m2k2jqcc21p5qsb36n7l5a5zcs8-php-7.1.19/sbin/* to /nix/store/q5m62m2k2jqcc21p5qsb36n7l5a5zcs8-php-7.1.19/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/98ydmdkm5v9gg0k4a0d8qpxl84qcv4cp-php-7.1.19-dev
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/98ydmdkm5v9gg0k4a0d8qpxl84qcv4cp-php-7.1.19-dev
checking for references to /build in /nix/store/98ydmdkm5v9gg0k4a0d8qpxl84qcv4cp-php-7.1.19-dev...
/nix/store/yr9fci7ar1mjf6q0608zx9sfskzvjd38-php-5.6.36
/nix/store/8izflwahbzl7zm6fgx4hhdhv82mjvnvl-php-7.0.30
/nix/store/q5m62m2k2jqcc21p5qsb36n7l5a5zcs8-php-7.1.19

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php72

Partial log (click to expand)

/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7...
moving /nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/sbin/* to /nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/gpb3rxw2g127fn488q94s8q00lx01lpb-php-7.2.7-dev
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gpb3rxw2g127fn488q94s8q00lx01lpb-php-7.2.7-dev
checking for references to /build in /nix/store/gpb3rxw2g127fn488q94s8q00lx01lpb-php-7.2.7-dev...
/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/n86k15k75jfjqx7k4lzprj055pm7ssjn-bash-4.4-p23/bin/sh"
/nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/n86k15k75jfjqx7k4lzprj055pm7ssjn-bash-4.4-p23/bin/sh"
/nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/n86k15k75jfjqx7k4lzprj055pm7ssjn-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7...
moving /nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7/sbin/* to /nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/qfz3prgw0zskcfjs55mk6wdpa31j92f7-php-7.2.7-dev
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qfz3prgw0zskcfjs55mk6wdpa31j92f7-php-7.2.7-dev
checking for references to /build in /nix/store/qfz3prgw0zskcfjs55mk6wdpa31j92f7-php-7.2.7-dev...
/nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php72

Partial log (click to expand)

these derivations will be built:
  /nix/store/9iy5a6mb5bkn3nw0g4hjpanj76aiqkn1-php-7.2.7.drv
waiting for locks or build slots...
/nix/store/mq49nzix08asryi8d005i4g1v633f0ii-php-7.2.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/bin/peardev: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/bin/pecl: interpreter directive changed from "/bin/sh" to "/nix/store/fcyxw5aslw3a82p33x5lhckj0mr6g1s4-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7...
moving /nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/sbin/* to /nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/gpb3rxw2g127fn488q94s8q00lx01lpb-php-7.2.7-dev
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/gpb3rxw2g127fn488q94s8q00lx01lpb-php-7.2.7-dev
checking for references to /build in /nix/store/gpb3rxw2g127fn488q94s8q00lx01lpb-php-7.2.7-dev...
/nix/store/zmn3m7z9gmqxwvq52qz4cli8qzz8pg8b-php-7.2.7

talyz
talyz approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Currently, I have to override this for my deployments, which entails recompiling php on the webservers..

@globin globin merged commit e0d23b1 into NixOS:master Jul 27, 2018
@etu etu deleted the php-mysqlnd branch July 29, 2018 18:48
@schneefux schneefux mentioned this pull request Aug 5, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @GrahamcOfBorg @talyz @globin