Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 52.9.1 -> 60.0 #44603

Merged
merged 2 commits into from Aug 11, 2018
Merged

thunderbird, thunderbird-bin: 52.9.1 -> 60.0 #44603

merged 2 commits into from Aug 11, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Aug 7, 2018 •
edited

Motivation for this change
  • various improvements and fixes

https://www.thunderbird.net/en-US/thunderbird/60.0/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@samueldr
Copy link
Member

samueldr commented Aug 7, 2018

This probably should be backported to 18.03; if others disagree please tell. If you don't or can't do the backport, please ping me and I'll oblige once this is merged.

Thanks!

@taku0 taku0 changed the title WIP: thunderbird, thunderbird-bin: 52.9.1 -> 60.0 thunderbird, thunderbird-bin: 52.9.1 -> 60.0 Aug 8, 2018
@taku0
Copy link
Contributor Author

taku0 commented Aug 8, 2018

Now, ready to merge 😃.

@timokau
Copy link
Member

timokau commented Aug 11, 2018

@GrahamcOfBorg build thunderbird thunderbird-bin

@samueldr why do you think this should be backported?

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: thunderbird, thunderbird-bin

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: thunderbird

The following builds were skipped because they don't evaluate on x86_64-linux: thunderbird-bin

Partial log (click to expand)

make[3]: Leaving directory '/build/objdir/dom/xslt/xslt'
make[3]: Entering directory '/build/objdir/dom/performance'
mkdir -p '.deps/'
/nix/store/jlbpa06dm81jvbb9jklf5dgvxxad6lgd-gcc-wrapper-7.3.0/bin/g++ -o Unified_cpp_dom_performance0.o -c -I/build/objdir/dist/stl_wrappers -I/build/objdir/dist/system_wrappers -include /build/thunderbird-60.0/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/build/thunderbird-60.0/dom/performance -I/build/objdir/dom/performance -I/build/objdir/dist/include -I/nix/store/swx05x4p896z3r2nq1ks5rnv4jgcq3r0-nspr-4.19-dev/include -I/nix/store/w38dc6h0cnd4k3yc2bngc1jia4kf2yyp-nss-3.38-dev/include/nss -I/nix/store/c0mlsv9rv1i9nrzxkjlkfrmc9fwl9syn-pixman-0.34.0/include/pixman-1 -fPIC -DMOZILLA_CLIENT -include /build/objdir/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++1z-compat -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -Wformat-security -Wformat-overflow=2 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -I/nix/store/mpayk2qxxnjzg9imiixbfg7zcqjjpy9m-icu4c-59.1-dev/include -freorder-blocks -O2 -fomit-frame-pointer  -MD -MP -MF .deps/Unified_cpp_dom_performance0.o.pp   /build/objdir/dom/performance/Unified_cpp_dom_performance0.cpp
libdom_u2f.a.desc
rm -f libdom_u2f.a
/build/objdir/_virtualenv/bin/python /build/thunderbird-60.0/config/expandlibs_gen.py -o libdom_u2f.a.desc Unified_cpp_dom_u2f0.o
make[3]: Leaving directory '/build/objdir/dom/u2f'
building of '/nix/store/1lnaj9408byrlcg6y6mzn5njqplihvgq-thunderbird-60.0.drv' timed out after 1800 seconds
error: build of '/nix/store/1lnaj9408byrlcg6y6mzn5njqplihvgq-thunderbird-60.0.drv' failed

@vcunat
Copy link
Member

vcunat commented Aug 11, 2018

Backport: I don't know if 52.x is to be maintained much longer, but I'd expect we should wait for 60.1 at least, according to information from the web:

Thunderbird version 60.0 is only offered as direct download from thunderbird.net and not as upgrade from Thunderbird version 52 or earlier. A future version 60.1 will provide updates from earlier versions.

@samueldr
Copy link
Member

@samueldr why do you think this should be backported?

The current set of general guidelines for backports list thunderbird specifically. This also would be subject to the "Extremely security-sensitive software" (imho) even if it wasn't named.

Though, as @vcunat seems to have found, it looks like this isn't (yet) an upgrade to version 52. It can then probably wait until it becomes one (as stated by upstream).

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: thunderbird

The following builds were skipped because they don't evaluate on aarch64-linux: thunderbird-bin

Partial log (click to expand)

libtoolkit_components_terminator.a.desc
rm -f libtoolkit_components_terminator.a
make[3]: Leaving directory '/build/objdir/toolkit/components/thumbnails'
libtoolkit_system_unixproxy.a.desc
rm -f libtoolkit_system_unixproxy.a
/build/objdir/_virtualenv/bin/python /build/thunderbird-60.0/config/expandlibs_gen.py -o libtoolkit_components_terminator.a.desc nsTerminator.o
/build/objdir/_virtualenv/bin/python /build/thunderbird-60.0/config/expandlibs_gen.py -o libtoolkit_system_unixproxy.a.desc nsUnixSystemProxySettings.o
make[3]: Leaving directory '/build/objdir/toolkit/profile'
building of '/nix/store/0fmqdgnkl159vhqn2a98x5wfymf3ycs1-thunderbird-60.0.drv' timed out after 3600 seconds
error: build of '/nix/store/0fmqdgnkl159vhqn2a98x5wfymf3ycs1-thunderbird-60.0.drv' failed

vcunat
vcunat approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to run OK for me.

@vcunat vcunat merged commit 4ce863e into NixOS:master Aug 11, 2018
vcunat added a commit that referenced this pull request Aug 11, 2018
@vcunat
Merge #44603: thunderbird*: 52.9.1 -> 60.0
d4741d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@taku0 @samueldr @timokau @GrahamcOfBorg @vcunat @edolstra @pSub