animbar: init at 1.2 #44608
Merged
animbar: init at 1.2 #44608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeji
reviewed
Aug 7, 2018
|
|
||
| nativeBuildInputs = [ cmake ]; | ||
|
|
||
| buildInputs = [ qt4 file ]; |
There was a problem hiding this comment.
Have you tried to build this with qt5? We are trying to get rid of qt4 in nixpkgs, see #33248 .
There was a problem hiding this comment.
Yes, I have tried. It fails to build without qt4.
Regarding removal of qt4: I've not involved with the discussion so far, but I'm in the camp of @vcunat of peaceful coexistence. I see no point in removing an entire toolkit from Nixpkgs 'just because you can'. Like in the case of this software: I'm not aware of a real equivalent. It does its (simple but unique) job. And it is uncertain whether it will ever be changed to some new version of Qt - what need would there be.
qt4 stands for a decade of free software history. If you don't have any software that uses qt4 installed, it does not burden you. And if you want to use it, you are willing to pay the 'price' of extra storage. Of course, in case of software that can be built with both there is no need to have two versions - and moving those to "qt5 exclusive" is a sane thing to optimise the common experience.... but removal isn't necessary.
There was a problem hiding this comment.
Yes, I have tried. It fails to build without qt4.
Fine, that's all I wanted to know. My opionion on the general issue is that, if a package supports both qt4 and qt5, we should prefer qt5. But there's no reason to refuse packages that need qt4.
|
@GrahamcOfBorg build animbar |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: animbar Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: animbar Partial log (click to expand)
|
xeji
approved these changes
Aug 7, 2018
|
Failure on aarch64-linux (full log) Attempted: animbar Partial log (click to expand)
|
|
timeout building qt ... unrelated. |
|
I tried porting it to Qt5 and sent the patch to authors jtojnar/animbar@1ae854e |
|
@jtojnar: Great! Hope they respond. meanwhile we could add a patchPhase, with your patch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unusual animation tool that can be used to create physical animations.
Things done
sandboxinnix.confon non-NixOS)./result/bin/)