Fixes underlying logic of slice_when / chunk_while to handle 1 element collections #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enumerables with 1 element Fixes jruby#5275. Instead of checking for size 1 at the beginning, this change sets a flag that never gets modified if `each_cons(2)` does not get called. This happens in the case of 1 element Enumerables. The previous behavior was fine for Enumerables that respond to `size` but fails otherwise.
mejackreed
changed the title
|
@mejackreed sorry we did not merge this a lot sooner. |
|
No problem. Thanks for accepting the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerables with 1 element
Fixes #5275. Instead of checking for size 1 at the beginning, this change sets a
flag that never gets modified if
each_cons(2)does not get called.This happens in the case of 1 element Enumerables. The previous
behavior was fine for Enumerables that respond to
sizebut failsotherwise.