Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sieve-connect: Package is supported everywhere #44627

Closed
wants to merge 1 commit into from
Closed

sieve-connect: Package is supported everywhere #44627

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Aug 7, 2018

Motivation for this change

I'm using Linux and sieve-connect works here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dasJ
sieve-connect: Package is supported everywhere
e2aa231 
The software is written in Perl and hence compatible
@xeji
Copy link
Contributor

xeji commented Aug 7, 2018

I believe you might misunderstand the platform definitions:
platforms.unix means unix-like platforms, this includes platfoms.linux and darwin.
Hydra already builds sieve-connect for linux and darwin.
So this change doesn't make sense unless you mean to support exotic platforms like windows 😄

@xeji xeji closed this Aug 7, 2018
@dasJ dasJ deleted the patch-1 branch August 7, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @xeji @GrahamcOfBorg