fusiondirectory: Init at 1.2.3 #44629
Conversation
| ]; | ||
|
|
||
| nativeBuildInputs = [ makeWrapper ]; | ||
| phases = [ "unpackPhase" "patchPhase" "installPhase" ]; |
There was a problem hiding this comment.
It is generally more robust to disable problematic phases rather than explicitly listing phases. Might not matter for this package specifically, but missing important phases is a source of bugs.
| sed 's/@@plugins@@/"${lib.concatStringsSep "\", \"" plugins}"/g' '${./setup-plugins.patch}' > setup-plugins.patch | ||
| ''; | ||
|
|
||
| patches = [ "setup-plugins.patch" ]; |
There was a problem hiding this comment.
I think this should be patches = [ ./setup-plugins.patch ];
There was a problem hiding this comment.
No, in the patch phase, I patch this patch in prePatch and write it to $PWD (see line 64)
There was a problem hiding this comment.
I see, but that's quite confusing and not how that attr is usually used ...
There was a problem hiding this comment.
To elaborate, I'd find it more intuitive if the patch was applied via the standard patch phase and the requisite substitutions performed in postPatch. You could reasonably argue that it works out to the same thing, but there is value in uniformity & sticking to the standard phases as much as possible. I at least am hesitant to merge stuff if I have to spend time trying to figure out how the recipe deviates from the standard boilerplate stuff, absent a clear rationale.
|
@joachifm I redid and rebased the PR, hopefully it's ok now ;) |
|
It doesn't appear that my comments have been addressed. Or is that merely a github UI issue? |
|
Nah, just me being too dumb to use git :/ Pushed now |
|
Ping @joachifm before it breaks again :/ |
|
Ping again @joachifm |
|
Are there still reasons to not merge this? |
|
@GrahamcOfBorg build fusiondirectory |
|
@dasJ do you have access to a mac so that you could fix the build error on x86_64-darwin? |
|
Stale, it's outdated |
Motivation for this change
I'm using Fusiondirectory to manage my LDAP tree with users, groups and associated permissions.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)