Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups-toshiba-estudio: 7.51 -> 7.89 #43850

Merged
merged 1 commit into from Jul 29, 2018
Merged

cups-toshiba-estudio: 7.51 -> 7.89 #43850

merged 1 commit into from Jul 29, 2018

Conversation

alanpearce
Copy link
Contributor

@alanpearce alanpearce commented Jul 20, 2018 •
edited

Motivation for this change

Adding pkgs.cups-toshiba-estudio to services.printing.drivers no longer works (404 on download URL)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
  • Tested printing manually

@xeji
Copy link
Contributor

xeji commented Jul 29, 2018

unfree package, builds locally

@xeji xeji merged commit 8aecf68 into NixOS:master Jul 29, 2018
@alanpearce alanpearce deleted the update-estudio branch July 30, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alanpearce @xeji @GrahamcOfBorg @Janik-Haag