Compiler: give error if constant has NoReturn type (#6411)

crystal-lang · Jul 20, 2018 · 02a78a8 · 02a78a8
1 parent 1b83706
commit 02a78a8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/spec/compiler/semantic/const_spec.cr b/spec/compiler/semantic/const_spec.cr
@@ -373,4 +373,17 @@ describe "Semantic: const" do
       ),
       "can't return from constant"
   end
+
+  it "errors if constant has NoReturn type (#6139)" do
+    assert_error %(
+      lib LibFoo
+        fun foo : NoReturn
+      end
+
+      FOO = LibFoo.foo
+
+      FOO
+      ),
+      "constant FOO has illegal type NoReturn"
+  end
 end
diff --git a/src/compiler/crystal/semantic/cleanup_transformer.cr b/src/compiler/crystal/semantic/cleanup_transformer.cr
@@ -195,6 +195,10 @@ module Crystal
         unless const.value.type?
           node.raise "can't infer type of constant #{const} (maybe the constant refers to itself?)"
         end
+
+        if const.value.type.no_return?
+          node.raise "constant #{const} has illegal type NoReturn"
+        end
       end
 
       node.value = node.value.transform self