Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singular: 4.1.1p1 -> 4.1.1p2 #43853

Merged
merged 1 commit into from Jul 23, 2018
Merged

Conversation

timokau
Copy link
Member

@timokau timokau commented Jul 20, 2018

Motivation for this change

Minor patch update and some formatting improvements.

I have also added myself as the maintainer and simplified the version attribute (at the cost of some complexity for computing the source URL). That should help the package update bot in doing our work for us.

That is not necessary for this to be merged, but it would be nice if someone with access to a 32 bit, x86 linux machine could test this build. I'd guess that whatever issue there was with that is fixed by now.

@7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: singular

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/0l6szffli36192pywynmn44940snm1x0-singular-4.1.1p2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2

@7c6f434c
Copy link
Member

@GrahamcOfBorg build pkgsi686Linux.singular

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsi686Linux.singular

Partial log (click to expand)

Cannot nix-instantiate `pkgsi686Linux.singular' because:
�[31;1merror:�[0m assertion failed at �[1m/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/stage.nix�[0m:153:21

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pkgsi686Linux.singular

Partial log (click to expand)

copying path '/nix/store/wgjvikj5y8600n0s4ig3bw326wzklp34-curl-7.60.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/cq1j6j4p0hiblcm65m6b5r38fzj7irr7-gnugrep-3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/vb833mk26ani944lq22aypkkyd7r9d4i-stdenv-linux' from 'https://cache.nixos.org'...
copying path '/nix/store/s1qqva75n8xhmzi0f1i6b813xxz3ahv1-autoconf-2.69' from 'https://cache.nixos.org'...
copying path '/nix/store/zw4znrg59m27w811fb7srvgz50n3inq7-automake-1.16.1' from 'https://cache.nixos.org'...
copying path '/nix/store/fxc1zjprywzcisggmwpd25nw8r2r9l5l-help2man-1.47.6' from 'https://cache.nixos.org'...
copying path '/nix/store/nxz9sxh7l3ksr2mqz519af6lhsp2ai5p-openssl-1.0.2o-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/66x72nd4cr6iik9qh5icmblkh1gzgm33-openssl-1.0.2o-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/njd200xbyl3v6sjg04qrx9ml38y4y4sk-curl-7.60.0-dev' from 'https://cache.nixos.org'...
error: a 'i686-linux' is required to build '/nix/store/zri11v108yx0s6hca3p1sv66vjc0a4ld-singular-4.1.1p2.tar.gz.drv', but I am a 'aarch64-linux'

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pkgsi686Linux.singular

Partial log (click to expand)

collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:1182: Singular] Error 1
make[3]: Leaving directory '/build/singular-4.1.1/Singular'
make[2]: *** [Makefile:2026: install-recursive] Error 1
make[2]: Leaving directory '/build/singular-4.1.1/Singular'
make[1]: *** [Makefile:2352: install] Error 2
make[1]: Leaving directory '/build/singular-4.1.1/Singular'
make: *** [Makefile:656: install-recursive] Error 1
builder for '/nix/store/a1k5rmrs30fhbl0l9a45jjjy1ca4g04r-singular-4.1.1p2.drv' failed with exit code 2
error: build of '/nix/store/a1k5rmrs30fhbl0l9a45jjjy1ca4g04r-singular-4.1.1p2.drv' failed

@timokau
Copy link
Member Author

timokau commented Jul 21, 2018

That looks like it might be a cross-compilation error, I'm not sure.

Let's just merge this as-is.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/ii0wahs0n8l1p6ad9rmbq8jgzl9bf2d3-singular-4.1.1p2

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: singular

Partial log (click to expand)

making ZZ_pEXTest
make[1]: Entering directory '/build/ntl-11.2.1/src'
./libtool-build/libtool --tag=CXX --mode=link g++ -I../include -I.  -g -O2 -pthread  -o ZZ_pEXTest ZZ_pEXTest.cpp libntl.la #LSHAR
libtool: link: g++ -I../include -I. -g -O2 -pthread -o .libs/ZZ_pEXTest ZZ_pEXTest.cpp  ./.libs/libntl.so -L/nix/store/k15acciycff39mifhdrar2i9q0gd0bkh-ntl-11.2.1/lib -L/nix/store/5fmjd54c5g7a41b0f38r5i4qnjdl8ln6-gf2x-1.2/lib /nix/store/jvz2yldc7kcfxrfwi44dys82rf9qgwwl-gmp-6.1.2/lib/libgmp.so /nix/store/5fmjd54c5g7a41b0f38r5i4qnjdl8ln6-gf2x-1.2/lib/libgf2x.so /nix/store/i5znwsdi9yybfydd1kbdrsq5s4phjm93-gcc-7.3.0-lib/lib/../lib64/libstdc++.so -lm -pthread -Wl,-rpath -Wl,/nix/store/k15acciycff39mifhdrar2i9q0gd0bkh-ntl-11.2.1/lib -Wl,-rpath -Wl,/nix/store/jvz2yldc7kcfxrfwi44dys82rf9qgwwl-gmp-6.1.2/lib -Wl,-rpath -Wl,/nix/store/5fmjd54c5g7a41b0f38r5i4qnjdl8ln6-gf2x-1.2/lib -Wl,-rpath -Wl,/nix/store/i5znwsdi9yybfydd1kbdrsq5s4phjm93-gcc-7.3.0-lib/lib/../lib64
make[1]: Leaving directory '/build/ntl-11.2.1/src'
running ZZ_pEXTest
building of '/nix/store/4yqnn871nv88lyfk2349q1b8fv9m917v-ntl-11.2.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/hhc8h2a1cb4k0vpvgn664lsmyv0gk3pw-flint-2.5.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/h8a9nffam1fkfjb875z16wisv00r03py-singular-4.1.1p2.drv': 2 dependencies couldn't be built
error: build of '/nix/store/h8a9nffam1fkfjb875z16wisv00r03py-singular-4.1.1p2.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: singular

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@7c6f434c
Copy link
Member

@timokau pkgsi686Linux are 32-bit native builds using 32-bit mode of 64-bit CPU.

Maybe giving up on 32-bit is OK; any ideas about the master-changes-induced failures.

@timokau
Copy link
Member Author

timokau commented Jul 23, 2018

Maybe giving up on 32-bit is OK

Yes that's what I meant by getting this merged as-is. 32 bit builds are still disabled, I just added a comment in case somebody with a 32 bit system wants to figure it out.

any ideas about the master-changes-induced failures.

Which failures? I'm not sure why @Mic92 merged master (merge conflict?). In case you're talking about the ofBorg failure, that seems to be a timeout.

(I wish ofBorg would allow me to get a raw dump of the log.)

@timokau
Copy link
Member Author

timokau commented Jul 23, 2018

I've squashed this (I hope @Mic92 doesn't mind) because I think we should avoid intermediate commits that break eval. I also amended the comment text.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: singular

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/rvmdwp45y1npirsq8bsj9ggzmxxjdddv-singular-4.1.1p2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/qa36xabizk4iv7kbb4gk7h55vjbbqjhm-singular-4.1.1p2

@7c6f434c 7c6f434c merged commit ef4d546 into NixOS:master Jul 23, 2018
@timokau timokau deleted the singular-4.1.1p1 branch July 23, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants