New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
singular: 4.1.1p1 -> 4.1.1p2 #43853
singular: 4.1.1p1 -> 4.1.1p2 #43853
Conversation
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: singular Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: singular Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: singular Partial log (click to expand)
|
@GrahamcOfBorg build pkgsi686Linux.singular |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsi686Linux.singular Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: pkgsi686Linux.singular Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: pkgsi686Linux.singular Partial log (click to expand)
|
That looks like it might be a cross-compilation error, I'm not sure. Let's just merge this as-is. |
Success on aarch64-linux (full log) Attempted: singular Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: singular Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: singular Partial log (click to expand)
|
@timokau Maybe giving up on 32-bit is OK; any ideas about the |
Yes that's what I meant by getting this merged as-is. 32 bit builds are still disabled, I just added a comment in case somebody with a 32 bit system wants to figure it out.
Which failures? I'm not sure why @Mic92 merged master (merge conflict?). In case you're talking about the ofBorg failure, that seems to be a timeout. (I wish ofBorg would allow me to get a raw dump of the log.) |
2dfcfa9
to
024c235
Compare
I've squashed this (I hope @Mic92 doesn't mind) because I think we should avoid intermediate commits that break eval. I also amended the comment text. |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: singular Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: singular Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: singular Partial log (click to expand)
|
Motivation for this change
Minor patch update and some formatting improvements.
I have also added myself as the maintainer and simplified the version attribute (at the cost of some complexity for computing the source URL). That should help the package update bot in doing our work for us.
That is not necessary for this to be merged, but it would be nice if someone with access to a 32 bit, x86 linux machine could test this build. I'd guess that whatever issue there was with that is fixed by now.
@7c6f434c
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)