appleseed: Fix non-executable items and Python bindings #43859

Hodapp87 · 2018-07-20T18:04:29Z

Motivation for this change

I realized a few things:

I wasn't actually building the Python bindings to Appleseed because Boost was missing Python bindings and because I was using the wrong CMake flags (and this made some comments also wrong)
The build was failing to mark some things executable in the bin directory (which I didn't realize were even supposed to be executable), and this was breaking some less-obvious features when using Appleseed with Blender via Blenderseed.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

FRidh · 2018-07-20T19:17:18Z

Please expose the Python bindings through python-packages.nix. See boost as an example.

Hodapp87 · 2018-07-20T19:27:22Z

Completely didn't think of that. As in

nixpkgs/pkgs/top-level/python-packages.nix

Line 1151 in 5fba38d

boost = toPythonModule (pkgs.boost.override {

?

FRidh · 2018-07-20T19:33:09Z

Right.

FRidh · 2018-07-20T19:33:50Z

disabledIf isPy3k can be used in case the Python 3 bindings don't function.

FRidh · 2018-07-21T06:00:59Z

@GrahamcOfBorg build appleseed python.pkgs.appleseed

GrahamcOfBorg · 2018-07-21T06:01:12Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: appleseed, python.pkgs.appleseed

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-21T06:28:34Z

Success on x86_64-linux (full log)

Attempted: appleseed, python.pkgs.appleseed

Partial log (click to expand)

shrinking /nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/lib/python2.7/appleseed/_appleseedpython.so
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/lib  /nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/bin
patching script interpreter paths in /nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta
/nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/bin/rendermanager.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/r99pik3abzrizbka8906ccs7vj837356-python-2.7.15/bin/python"
/nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/bin/convertmany.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/r99pik3abzrizbka8906ccs7vj837356-python-2.7.15/bin/python"
/nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/bin/cleanmany.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/r99pik3abzrizbka8906ccs7vj837356-python-2.7.15/bin/python"
/nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/bin/rendermany.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/r99pik3abzrizbka8906ccs7vj837356-python-2.7.15/bin/python"
/nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta/bin/rendernode.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/r99pik3abzrizbka8906ccs7vj837356-python-2.7.15/bin/python"
checking for references to /build in /nix/store/wfzmv1rp9phv2xfy64jvc721m41013ll-appleseed-1.9.0-beta...

GrahamcOfBorg · 2018-07-21T07:07:28Z

Failure on aarch64-linux (full log)

Attempted: appleseed, python.pkgs.appleseed

Partial log (click to expand)

                 from ../../WebCore/generated/JSSVGMaskElement.h:26,
                 from ../../WebCore/generated/JSSVGMaskElement.cpp:25:
../../JavaScriptCore/wtf/NullPtr.h:48:1: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++11-compat]
 extern std::nullptr_t nullptr;
 ^~~~~~
building of '/nix/store/1zzsswwwv4wpkdw297garimd7rm80dvh-qt-4.8.7.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/rnsl83vg3x7aaiq63jryizqb4pzy2p20-python2.7-PyQt-x11-gpl-4.12.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9idgw05kxriqcmkpc496h7bw45pxjk58-seexpr-2.11.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/icipn6vybrd5l4c17x3qswnisfgn0cr0-appleseed-1.9.0-beta.drv': 5 dependencies couldn't be built
error: build of '/nix/store/icipn6vybrd5l4c17x3qswnisfgn0cr0-appleseed-1.9.0-beta.drv' failed

FRidh · 2018-07-22T06:45:55Z

@GrahamcOfBorg build appleseed python.pkgs.appleseed

GrahamcOfBorg · 2018-07-22T06:46:10Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: appleseed, python.pkgs.appleseed

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-22T07:47:13Z

Failure on x86_64-linux (full log)

Attempted: appleseed, python.pkgs.appleseed

Partial log (click to expand)

common.copy /nix/store/8yvcncrdhyrdw46m6piirgh9d7yk1l03-boost-1.65.1-dev/include/boost/smart_ptr/detail/sp_has_sync.hpp
common.copy /nix/store/8yvcncrdhyrdw46m6piirgh9d7yk1l03-boost-1.65.1-dev/include/boost/smart_ptr/detail/sp_forward.hpp
common.copy /nix/store/8yvcncrdhyrdw46m6piirgh9d7yk1l03-boost-1.65.1-dev/include/boost/smart_ptr/detail/sp_disable_deprecated.hpp
common.copy /nix/store/8yvcncrdhyrdw46m6piirgh9d7yk1l03-boost-1.65.1-dev/include/boost/smart_ptr/detail/sp_counted_impl.hpp
common.copy /nix/store/8yvcncrdhyrdw46m6piirgh9d7yk1l03-boost-1.65.1-dev/include/boost/smart_ptr/detail/sp_counted_base_w32.hpp
common.copy /nix/store/8yvcncrdhyrdw46m6piirgh9d7yk1l03-boost-1.65.1-dev/include/boost/smart_ptr/detail/sp_counted_base_vacpp_ppc.hpp
common.copy /nix/store/8yvcncrdhyrdw46m6piirgh9d7yk1l03-boost-1.65.1-dev/include/boost/smart_ptr/detail/sp_counted_base_sync.hpp
building of '/nix/store/ccfbj7rzhb2f84rcmx7ql2zgzlfa6w08-boost-1.65.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/032igrdwppk5w9z82011kcbbg1qm4cvq-appleseed-1.9.0-beta.drv': 1 dependencies couldn't be built
error: build of '/nix/store/032igrdwppk5w9z82011kcbbg1qm4cvq-appleseed-1.9.0-beta.drv' failed

GrahamcOfBorg · 2018-07-22T07:52:25Z

Failure on aarch64-linux (full log)

Attempted: appleseed, python.pkgs.appleseed

Partial log (click to expand)

 QList<QtResourceFile *> QtQrcManager::resourceFilesOf(const QString &resourcePath) const
                         ^~~~~~~~~~~~
shared/qtresourceeditordialog.cpp:393:12: warning: '{anonymous}::QtQrcFile* {anonymous}::QtQrcManager::qrcFileOf({anonymous}::QtResourceFile*) const' defined but not used [-Wunused-function]
 QtQrcFile *QtQrcManager::qrcFileOf(QtResourceFile *resourceFile) const
            ^~~~~~~~~~~~
building of '/nix/store/1zzsswwwv4wpkdw297garimd7rm80dvh-qt-4.8.7.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/rnsl83vg3x7aaiq63jryizqb4pzy2p20-python2.7-PyQt-x11-gpl-4.12.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9idgw05kxriqcmkpc496h7bw45pxjk58-seexpr-2.11.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/icipn6vybrd5l4c17x3qswnisfgn0cr0-appleseed-1.9.0-beta.drv': 5 dependencies couldn't be built
error: build of '/nix/store/icipn6vybrd5l4c17x3qswnisfgn0cr0-appleseed-1.9.0-beta.drv' failed

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jul 20, 2018

appleseed: Fix non-executable items and Python bindings

88fe696

Hodapp87 force-pushed the appleseed_190b_fix_python branch from 2f231a1 to 88fe696 Compare July 21, 2018 01:43

Hodapp87 requested a review from FRidh as a code owner July 21, 2018 01:43

GrahamcOfBorg added 6.topic: python 8.has: package (new) labels Jul 21, 2018

FRidh merged commit 6275a31 into NixOS:master Jul 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

appleseed: Fix non-executable items and Python bindings #43859

appleseed: Fix non-executable items and Python bindings #43859

Hodapp87 commented Jul 20, 2018

FRidh commented Jul 20, 2018

Hodapp87 commented Jul 20, 2018 •

edited

FRidh commented Jul 20, 2018

FRidh commented Jul 20, 2018

FRidh commented Jul 21, 2018

GrahamcOfBorg commented Jul 21, 2018

GrahamcOfBorg commented Jul 21, 2018

GrahamcOfBorg commented Jul 21, 2018

FRidh commented Jul 22, 2018

GrahamcOfBorg commented Jul 22, 2018

GrahamcOfBorg commented Jul 22, 2018

GrahamcOfBorg commented Jul 22, 2018

appleseed: Fix non-executable items and Python bindings #43859

appleseed: Fix non-executable items and Python bindings #43859

Conversation

Hodapp87 commented Jul 20, 2018

Motivation for this change

Things done

FRidh commented Jul 20, 2018

Hodapp87 commented Jul 20, 2018 • edited

FRidh commented Jul 20, 2018

FRidh commented Jul 20, 2018

FRidh commented Jul 21, 2018

GrahamcOfBorg commented Jul 21, 2018

GrahamcOfBorg commented Jul 21, 2018

GrahamcOfBorg commented Jul 21, 2018

FRidh commented Jul 22, 2018

GrahamcOfBorg commented Jul 22, 2018

GrahamcOfBorg commented Jul 22, 2018

GrahamcOfBorg commented Jul 22, 2018

Hodapp87 commented Jul 20, 2018 •

edited